Commit graph

51 commits

Author SHA1 Message Date
Romain Francoise
5b76833fd5 2005-09-24 Emilio C. Lopes <eclig@gmx.net>
* woman.el (woman-file-name):
	* wid-edit.el (widget-file-prompt-value)
	(widget-coding-system-prompt-value):
	* w32-fns.el (set-w32-system-coding-system):
	* vc.el (vc-version-diff, vc-annotate):
	* textmodes/reftex-auc.el (reftex-arg-cite)
	(reftex-arg-index-tag):
	* textmodes/refer.el (refer-get-bib-files):
	* textmodes/artist.el (artist-figlet-choose-font):
	* terminal.el (terminal-emulator):
	* replace.el (occur-read-primary-args):
	* rect.el (string-rectangle, string-insert-rectangle):
	* ps-print.el (ps-print-preprint):
	* progmodes/pascal.el (pascal-goto-defun):
	* progmodes/etags.el (visit-tags-table, visit-tags-table-buffer):
	* progmodes/compile.el (compilation-find-file):
	* printing.el (pr-interactive-n-up):
	* play/animate.el (animate-birthday-present):
	* net/rcompile.el (remote-compile):
	* man.el (man, Man-goto-section, Man-follow-manual-reference):
	* mail/rmailsum.el (rmail-summary-search-backward)
	(rmail-summary-search):
	* mail/rmailout.el (rmail-output-read-rmail-file-name)
	(rmail-output-read-file-name):
	* mail/rmail.el (rmail-search, rmail-search-backwards):
	* mail/mailabbrev.el (merge-mail-abbrevs, rebuild-mail-abbrevs):
	* locate.el (locate):
	* international/quail.el (quail-show-keyboard-layout):
	* international/mule.el (set-buffer-file-coding-system)
	(revert-buffer-with-coding-system, set-file-name-coding-system)
	(set-terminal-coding-system, set-keyboard-coding-system)
	(set-next-selection-coding-system):
	* international/mule-diag.el (describe-coding-system)
	(describe-font, describe-fontset):
	* international/mule-cmds.el (universal-coding-system-argument)
	(search-unencodable-char, describe-input-method)
	(set-language-environment, describe-language-environment):
	* international/codepage.el (codepage-setup):
	* international/code-pages.el (codepage-setup):
	* info.el (Info-search, Info-follow-reference)
	(Info-search-backward):
	* emacs-lisp/advice.el (ad-read-advised-function)
	(ad-read-advice-class, ad-clear-cache, ad-activate)
	(ad-deactivate, ad-update, ad-unadvise, ad-read-advice-name)
	(ad-enable-advice, ad-disable-advice, ad-remove-advice)
	(ad-read-regexp):
	* ediff-util.el (ediff-toggle-regexp-match):
	* ediff-ptch.el (ediff-prompt-for-patch-file):
	* dired-aux.el (dired-diff):
	* diff.el (diff):
	* cus-edit.el (custom-variable-prompt):
	* calendar/timeclock.el (timeclock-ask-for-project):
	* calc/calcalg3.el (calc-get-fit-variables):
	* calc/calc-store.el (calc-edit-variable)
	(calc-permanent-variable):
	* vc-mcvs.el (vc-mcvs-register):
	* shadowfile.el (shadow-define-literal-group):
	* woman.el (woman-file-name):
	* vc.el (vc-version-diff, vc-merge):
	* textmodes/reftex-index.el (reftex-index-complete-tag):
	* format.el (format-decode-buffer, format-decode-region):
	* emulation/viper-cmd.el (viper-read-string-with-history):
	* emacs-lisp/debug.el (cancel-debug-on-entry):
	* emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
	* ediff.el (ediff-merge-revisions)
	(ediff-merge-revisions-with-ancestor, ediff-revision):
	* completion.el (interactive-completion-string-reader):
	* calc/calc-prog.el (calc-user-define-formula):
	Follow convention for reading with the minibuffer.
2005-09-24 13:44:02 +00:00
Juanma Barranquero
6d74f7822d (compilation-error-regexp-alist, compilation-mode-font-lock-keywords):
Add defvars.
(checkdoc-interactive-loop): "?\ " -> "?\s".
2005-08-29 10:41:37 +00:00
Thien-Thi Nguyen
3731a85096 Update years in copyright notice; nfc. 2005-08-06 17:48:15 +00:00
Richard M. Stallman
b372cfa997 (checkdoc-make-overlay, checkdoc-overlay-put, checkdoc-delete-overlay)
(checkdoc-overlay-start, checkdoc-overlay-end)
(checkdoc-mode-line-update, checkdoc-char=):
Define such that compiler knows they are defined.

(checkdoc-call-eval-buffer): Deleted.  Use eval-buffer directly.
(checkdoc-read-event): Deleted.  Use read-event directly.
2005-07-16 17:16:57 +00:00
Richard M. Stallman
65a30f585c (checkdoc-proper-noun-list):
Check for "emacs", etc., as entire symbol, not just as word.
(checkdoc-file-comments-engine): Use regexp-quote on FN.
2005-07-08 22:54:57 +00:00
Lute Kamstra
3a35cf56e7 Update FSF's address. 2005-07-04 17:55:18 +00:00
Stefan Monnier
e8592238a1 (checkdoc-continue, checkdoc-comments, checkdoc-message-text, checkdoc-defun):
Fix format messages for calls to `error'.
2004-12-11 22:01:42 +00:00
Stefan Monnier
25d91d947f (checkdoc-this-string-valid-engine):
Don't tell to use \\{...} when it's already done.
2004-09-12 20:17:53 +00:00
Andreas Schwab
07051573a8 (checkdoc-minor-mode): Doc fix. 2004-05-08 16:38:33 +00:00
Stefan Monnier
f578d9f8aa (checkdoc-output-error-regex-alist): New var.
(checkdoc-output-font-lock-keywords): Remove error regexp.
(checkdoc-output-mode-map): Remove.
(checkdoc-output-mode): Derive from compilation-mode.
(checkdoc-find-error-mouse, checkdoc-find-error): Remove.
2004-04-23 22:25:17 +00:00
Stefan Monnier
780b142e2d (checkdoc-output-mode): Make it a normal major mode.
(checkdoc-buffer-label): Make sure the file name is meaningful.
(checkdoc-output-to-error-buffer): Remove.
(checkdoc-error, checkdoc-start-section): Rewrite.
2004-04-21 20:54:03 +00:00
Stefan Monnier
96ef1febd2 (checkdoc-output-mode-map, checkdoc-find-error-mouse, checkdoc-find-error):
Use posn-set-point to merge the mouse and non-mouse case.
2004-04-14 17:49:43 +00:00
Stefan Monnier
b008007c6a (checkdoc-error): Dont' assume point-min == 1.
(debug-ignored-errors): Add an entry.
2004-03-22 15:24:49 +00:00
Miles Bader
ab5796a9f9 Add arch taglines 2003-09-01 15:45:59 +00:00
Lute Kamstra
d547e25f45 (checkdoc-file-comments-engine): Use
`lm-commentary-end' to find the end of the commentary section.
2003-05-23 10:10:24 +00:00
Juanma Barranquero
b08b261e8b (checkdoc-display-status-buffer): Fix docstring.
(checkdoc-interactive, checkdoc-message-interactive): Make them perform spell
checking when appropriate.
(checkdoc-interactive-loop): Fix docstring and a few typos.
(checkdoc-interactive-ispell-loop)
(checkdoc-message-interactive-ispell-loop): New functions.
(checkdoc-next-error): Fix docstring.
(checkdoc-this-string-valid-engine): Fix typo.
(checkdoc-ispell-docstring-engine): Do test for checkdoc-autofix-flag = nil.
2003-03-28 17:38:50 +00:00
Juanma Barranquero
c6a7f93869 (checkdoc-minor-keymap): Add obsolescence declaration and remove redundant info
from docstring.
2003-02-05 23:15:01 +00:00
Juanma Barranquero
a1506d2977 Trailing whitepace deleted. 2003-02-04 13:24:35 +00:00
Richard M. Stallman
76efe10ec7 Don't define a name for the minor mode menu. 2002-12-23 17:59:54 +00:00
Markus Rost
90620d3dfb (checkdoc-minor-mode): Add group. 2002-11-18 04:36:18 +00:00
Markus Rost
b127be31b1 (checkdoc-find-error): Use get-file-buffer instead of get-buffer. 2002-11-07 16:52:04 +00:00
Richard M. Stallman
84003f382e (checkdoc, checkdoc-interactive)
(checkdoc-message-interactive, checkdoc-interactive-loop)
(checkdoc-current-buffer, checkdoc-continue, checkdoc-comments)
(checkdoc-defun):
Update checkdoc-spellcheck-documentation-flag correctly.
(checkdoc-ispell-docstring-engine): Don't test for
checkdoc-autofix-flag = nil.
2002-08-09 01:56:00 +00:00
Richard M. Stallman
7979633450 Fix doc typos. 2002-07-14 15:26:01 +00:00
Juanma Barranquero
01af482e4d (checkdoc-this-string-valid-engine): Fix typo. 2002-06-18 14:35:49 +00:00
Markus Rost
b7f30cf569 (checkdoc-minor-mode): Define it with define-minor-mode. 2002-05-12 19:08:48 +00:00
Richard M. Stallman
1c511be4d9 (checkdoc-this-string-valid-engine):
Replace foo-p as var name with foo-flag, not foo-p-flag.
2002-02-06 15:33:23 +00:00
Pavel Janík
110c171f4d Fix typo. 2002-01-13 10:09:20 +00:00
Sam Steingold
8a9463543d Converted backquote to the new style. 2001-11-27 15:52:52 +00:00
Richard M. Stallman
c13599b603 (princ-list, checkdoc-read-event, add-to-list): Delete compatibility code.
(checkdoc-next-message-error): Doc fix.
2001-11-17 22:51:11 +00:00
Richard M. Stallman
c9d557f595 (checkdoc-file-comments-engine):
Turn off error in some re-search-forward calls.
2001-11-11 20:06:58 +00:00
Stefan Monnier
2e89869265 (checkdoc-eval-defun): Call eval-defun
interactively so that C-u M-C-x still does edebug.
(checkdoc-sentencespace-region-engine): Don't force a double-space
after `.' if it doesn't look like an end-of-sentence.
(debug-ignored-errors): Add `disambiguate ...'.
2001-10-25 05:51:39 +00:00
Gerd Moellmann
9c07782ebd (checkdoc-this-string-valid-engine):
Check for '(' in column 0 of doc string.
2001-09-17 15:51:54 +00:00
Pavel Janík
e8af40eed4 Some fixes to follow coding conventions. 2001-07-16 12:23:00 +00:00
Gerd Moellmann
23b809c2a7 Fix autoload cookies. 2001-04-23 11:50:36 +00:00
Gerd Moellmann
1bd6facc63 (checkdoc-common-verbs-wrong-voice): Add
an antry for ``converts''.
2001-04-03 13:22:07 +00:00
Stefan Monnier
82bc80bfce (checkdoc-minor-mode) <defvar>: Remove.
(checkdoc-minor-mode-map): New map, replaces checkdoc-minor-keymap.
(checkdoc-minor-keymap): Backward compatibility.
(checkdoc-minor-menu): Don't bother checking checkdoc-minor-keymap.
(checkdoc-minor-mode) <defun>: Use easy-mmode-define-minor-mode.
(checkdoc-this-string-valid-engine): Be a bit more strict
to avoid matching substrings of `...' quoted vars/funs.
(checkdoc-defun-info): Only look for `interactive' if alone.
(debug-ignored-errors): Add "arg doesn't appear in docstring".
2000-11-14 20:11:23 +00:00
Dave Love
d8693181b0 (checkdoc-interactive-loop): Don't lose on a function with an empty
body.
2000-01-26 17:15:13 +00:00
Richard M. Stallman
995e028a96 (checkdoc-this-string-valid-engine):
Improve messages for capitalization of arg names,
for flag variables, for t and nil, for imperatives.
Call them imperatives rather than infinitives sans "to".
(checkdoc-common-verbs-wrong-voice): Add "moves".
(checkdoc-message-text-engine): Improve messages for y-or-n-p.

(checkdoc-file-comments-engine):
Don't convert comments from 3-semicolon to 2-semicolon.
That is a matter of style.
(checkdoc-triple-semi-comment-check-flag): Variable deleted.
(checkdoc-comments): Don't bind that variable.
1999-11-26 17:33:36 +00:00
Dave Love
eb83be8a1d (checkdoc-display-status-buffer): Avoid
Help mode for temp buffer.
(checkdoc-this-string-valid): Don't assume default comment-start.
1999-09-13 21:05:01 +00:00
Eric M. Ludlam
1a553b8be1 (checkdoc-sentencespace-region-engine): Protect a `forward-sexp' call
which could fail, and improved regex for ie, and eg abbreviations.
1998-10-04 12:37:28 +00:00
Eric M. Ludlam
84f473b019 (checkdoc-buffer-label): New function.
(checkdoc-start-section, checkdoc-error): Use `checkdoc-buffer-label'.
(checkdoc-this-string-valid-engine): Permit ? as terminating
 punctuation for first line sentence breaking.
(checkdoc-this-string-valid): When converting a comment into a doc
 string, make sure " chars are \".
(checkdoc-sentencespace-region-engine): Only do double space check
 if based on the variable `sentence-end-double-space'
1998-09-05 13:46:23 +00:00
Eric M. Ludlam
bca0d6075a (checkdoc): Updated commentary.
(checkdoc-autofix-flag): Updated doc.
(checkdoc-force-docstrings-flag): Updated doc.
(checkdoc-force-history-flag): New flag.
(checkdoc-triple-semi-comment-check-flag): Fixed name.
(checkdoc-spellcheck-documentation-flag): Fixed doc.
(checkdoc-ispell-lisp-words): Update default value.
(checkdoc-generate-compile-warnings-flag, checkdoc-proper-noun-list,
checkdoc-proper-noun-regexp, checkdoc-symbol-words): New variables.
(princ-list): Function created if it isn't bound.
(checkdoc-interactive): parts removed to `checkdoc-interactive-loop'.
(checkdoc,checkdoc-message-interactive): New function.
(checkdoc-interactive-loop): was in `checkdoc-interactive', then
added better keybindings, and better autofixing behavior,
Cursor now sits next to the error, forcing scrolling if needed,
and using a better centering algorithm, and much better error
navigation after choosing "f"ix.
(checkdoc-next-error): Added parameter ENABLE-FIX.
(checkdoc-next-message-error,checkdoc-recursive-edit): New functions.
(checkdoc-start): was `checkdoc', uses new note taking system.
(checkdoc-current-buffer, checkdoc-continue, checkdoc-comments):
Updated to use new note taking system.
(checkdoc-rogue-spaces, checkdoc-rogue-space-check-engine):
Added INTERACT parameter, uses new warnings functions.
(checkdoc-message-text, checkdoc-defun):
Updated to use new note taking system.
(checkdoc-ispell-current-buffer, checkdoc-ispell-interactive): fix doc.
(checkdoc-ispell-message-text, checkdoc-ispell-start): New function.
(checkdoc-create-error, checkdoc-error-text, checkdoc-error-start,
checkdoc-error-end, checkdoc-error-unfixable): New functions.
(checkdoc-minor-keymap): Updated keybinds to new interactive functions,
completely re-arranged the minor-mode menu.
(checkdoc-this-string-valid): Moved no doc-string warning here,
and added autofix if a comment already exists there.
(checkdoc-this-string-valid-engine): fix doc, robusted doc finder.
All previously returned errors now call `checkdoc-create-error'.
Moved no doc string warning out.  Update allowed punctuation at
end of first line.  Fixed up sentence joining.  Verb checking flag
now only checks the first line of a function.  Added more safe
conditions to ambiguous symbols.  Moved symbol quoting to end.
Added autofix for variables that should end in `-flag'.
Replaced use of `y-or-n-p' with `checkdoc-y-or-n-p'.
Reading checkdoc-param comment no longer depends on list syntax.
Fixed various error string spelling & format.
(checkdoc-in-sample-code-p): List starting with all caps word is
now condsidered sample code.
(checkdoc-in-example-string-p, checkdoc-proper-noun-region-engine,
checkdoc-sentencespace-region-engine): New functions.
(checkdoc-ispell-docstring-engine): Disable spell checking during
if user never wants interaction.  We don't have a non-interactive
spell checking method yet.
(checkdoc-file-comments-engine): Now set up to check all possible
conditions even after encountering an error.  Added auto-fixes
for history and commentary.  All previously returned errors now call
`checkdoc-create-error'.  Message spelling and format.
(checkdoc-message-text-search):
Moved parts to `checkdoc-message-text-next-string'.
(checkdoc-message-text-next-string): New function
(checkdoc-message-text-engine):  All previously returned errors
now call `checkdoc-create-error'.  Can find/skip 'format' call
after the call we are checking.  Added sentence/propernoun scans.
`y-or-n-p' checks and fixes are now more robust.
(checkdoc-y-or-n-p): New function.
(checkdoc-autofix-ask-replace): Update doc.  Protect match-data.
Correctly handle `checkdoc-autofix-flag' of 'never.  New behavior
with `checkdoc-autofix-flag' of 'automatic-then-never.  Better
overlay handling.
(checkdoc-output-font-lock-keywords): Updated to new output format.
(checkdoc-pending-errors): New variable.
(checkdoc-find-error): Updated to new output format.
(checkdoc-start-section, checkdoc-error): Improved the output.
(checkdoc-show-diagnostics): Smarter show algorithm.
1998-07-03 15:15:27 +00:00
Andreas Schwab
59c9da9d0a (checkdoc-autofix-flag): Use `other'
widget type.
1998-06-24 09:05:39 +00:00
Karl Heuer
6deb154314 (checkdoc-eval-defun): Doc fix.
(checkdoc-continue, checkdoc-tripple-semi-comment-check-flag): Ditto.
(checkdoc-common-verbs-wrong-voice): Use dotted pairs.
1998-06-19 19:21:23 +00:00
Richard M. Stallman
5fecb21aeb Many doc fixes.
Put two spaces between sentences.
(checkdoc-this-string-valid-engine): Fix message.
(checkdoc-ispell-lisp-words): Add "emacs".
1998-05-23 00:51:44 +00:00
Eric M. Ludlam
a4370a7744 Updated with latest version. Changes include:
Added checks for basics in messages using `error'.
Added check for symbols that are both functions and symbols.
    These references are ambiguous and should be prefixed with
    "function", or "variable".  Added auto-fix for this also.
Added auto fix for args that do not occur in the doc string.
Fixed question about putting a symbol in `quotes'.
Added spaces to the end of all y/n questions.
Added checks for y/n question endings to require "? "
1998-05-17 13:20:26 +00:00
Dan Nicolaescu
42dfe0ad13 *** empty log message *** 1998-04-18 19:48:40 +00:00
Eric M. Ludlam
04f3f5a2e3 Updated to 0.4.3:
Removed string check in basic doc search code.
Made the check for embeded key codes more robust from erronious checks.
1998-03-14 12:59:13 +00:00
Simon Marshall
883212ce69 Changed font-lock-reference-face to font-lock-constant-face. 1998-02-20 14:58:27 +00:00
Eric M. Ludlam
0a0a3dee18 Added some more comments in the commentary.
You can now `quote' symbols that look like keystrokes
When spell checking, meta variables can end in `th' or `s'.
1998-01-08 23:35:34 +00:00