procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prefer %S format over %s for non strings

Browse source 
* lisp/reveal.el (reveal-open-new-overlays, reveal-close-old-overlays):
* lisp/gnus/nnimap.el (nnimap-header-parameters)
(nnimap-make-process-buffer):
* lisp/gnus/nntp.el (nntp-make-process-buffer):
* lisp/progmodes/flymake.el (flymake--disable-backend):
* lisp/simple.el (next-error-internal):
Prefer `%S` format over `%s` for non strings.
This commit is contained in:
Stefan Monnier 2025-01-02 14:29:49 -05:00
parent 2a5725b99a
commit fba3c7ff3f
5 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lisp/gnus/nnimap.el
View file

@ -221,13 +221,13 @@ during splitting, which may be slow."
(push "BODYSTRUCTURE" params) (push "BODYSTRUCTURE" params)
(push (format (push (format
(if (nnimap-ver4-p) (if (nnimap-ver4-p)
"BODY.PEEK[HEADER.FIELDS %s]" "BODY.PEEK[HEADER.FIELDS %S]"
"RFC822.HEADER.LINES %s") "RFC822.HEADER.LINES %S")
(append '(Subject From Date Message-Id (append '(Subject From Date Message-Id
References In-Reply-To Xref) References In-Reply-To Xref)
nnmail-extra-headers)) nnmail-extra-headers))
params) params)
(format "%s" (nreverse params)))) (format "(%s)" (mapconcat #'identity (nreverse params) " "))))
(defvar nnimap--max-retrieve-headers 200) (defvar nnimap--max-retrieve-headers 200)
@ -386,7 +386,7 @@ during splitting, which may be slow."
(defun nnimap-make-process-buffer (buffer) (defun nnimap-make-process-buffer (buffer)
(with-current-buffer (with-current-buffer
(generate-new-buffer (format " *nnimap %s %s %s*" (generate-new-buffer (format " *nnimap %s %s %S*"
nnimap-address nnimap-server-port nnimap-address nnimap-server-port
buffer)) buffer))
(mm-disable-multibyte) (mm-disable-multibyte)

2
lisp/gnus/nntp.el
View file

@ -1189,7 +1189,7 @@ If SEND-IF-FORCE, only send authinfo to the server if the
"Create a new, fresh buffer usable for nntp process connections." "Create a new, fresh buffer usable for nntp process connections."
(with-current-buffer (with-current-buffer
(generate-new-buffer (generate-new-buffer
(format " *server %s %s %s*" (format " *server %s %s %S*"
nntp-address nntp-port-number buffer)) nntp-address nntp-port-number buffer))
(gnus-add-buffer) (gnus-add-buffer)
(mm-disable-multibyte) (mm-disable-multibyte)

2
lisp/progmodes/flymake.el
View file

@ -1236,7 +1236,7 @@ If MESSAGE-PREFIX, echo a message using that prefix."
(defun flymake--disable-backend (backend &optional explanation) (defun flymake--disable-backend (backend &optional explanation)
"Disable BACKEND because EXPLANATION. "Disable BACKEND because EXPLANATION.
If it is running also stop it." If it is running also stop it."
(flymake-log :warning "Disabling backend %s because %s" backend explanation) (flymake-log :warning "Disabling backend %s because %S" backend explanation)
(flymake--with-backend-state backend state (flymake--with-backend-state backend state
(setf (flymake--state-running state) nil (setf (flymake--state-running state) nil
(flymake--state-disabled state) explanation (flymake--state-disabled state) explanation

4
lisp/reveal.el
View file

@ -145,7 +145,7 @@ Each element has the form (WINDOW . OVERLAY).")
(setq repeat t) (setq repeat t)
(condition-case err (condition-case err
(funcall open ol nil) (funcall open ol nil)
(error (message "!!Reveal-show (funcall %s %s nil): %s !!" (error (message "!!Reveal-show (funcall %S %S nil): %S !!"
open ol err) open ol err)
;; Let's default to a meaningful behavior to avoid ;; Let's default to a meaningful behavior to avoid
;; getting stuck in an infinite loop. ;; getting stuck in an infinite loop.
@ -189,7 +189,7 @@ Each element has the form (WINDOW . OVERLAY).")
open) open)
(condition-case err (condition-case err
(funcall open ol t) (funcall open ol t)
(error (message "!!Reveal-hide (funcall %s %s t): %s !!" (error (message "!!Reveal-hide (funcall %S %S t): %S !!"
open ol err))) open ol err)))
(overlay-put ol 'invisible inv)) (overlay-put ol 'invisible inv))
;; Remove the overlay from the list of open spots. ;; Remove the overlay from the list of open spots.

2
lisp/simple.el
View file

@ -393,7 +393,7 @@ To control which errors are matched, customize the variable
(next-error-found buffer (current-buffer)) (next-error-found buffer (current-buffer))
(when (or next-error-verbose (when (or next-error-verbose
(not (eq prev next-error-last-buffer))) (not (eq prev next-error-last-buffer)))
(message "Current locus from %s" next-error-last-buffer))))) (message "Current locus from %S" next-error-last-buffer)))))
(defun next-error-quit-window (from-buffer to-buffer) (defun next-error-quit-window (from-buffer to-buffer)
"Quit window of FROM-BUFFER when the prefix arg is 0. "Quit window of FROM-BUFFER when the prefix arg is 0.