diff --git a/doc/emacs/android.texi b/doc/emacs/android.texi index 2d95f5c8fef..edcbb971b98 100644 --- a/doc/emacs/android.texi +++ b/doc/emacs/android.texi @@ -378,20 +378,18 @@ definition documents, so your mileage may vary. @cindex EMACS_CLASS_PATH environment variable, Android Even when the location of the @command{libandroid-emacs.so} command is -known in advance, special configuration is required to run Emacs from +known in advance, special preparation is required to run Emacs from elsewhere than a subprocess of an existing Emacs session, as it must be made to understand the location of resources and shared libraries in or extracted from the installed application package. The OS command @command{pm path org.gnu.emacs} will print the location of the -application package, and the adjacent @file{lib} directory will hold -shared libraries extracted from the same, though the said command must -be invoked in a peculiar manner to satisfy system restrictions on -communication between pseudoterminal devices created by user -applications and system services such as the package manager, which is -to say, with the standard IO streams redirected to a real file or a -pipe. Such values, once established, must be specified in the -environment variables @code{EMACS_CLASS_PATH} and -@code{EMACS_LD_LIBRARY_PATH}, so that this sample shell script may be +application package, though the said command must be invoked in a +peculiar manner to satisfy system restrictions on communication between +pseudoterminal devices created by user applications and system services +such as the package manager, which is to say, with the standard IO +streams redirected to a real file or a pipe. This value, once +established, must be specified in the environment variables +@code{EMACS_CLASS_PATH}, so that this sample shell script may be installed as @code{emacs} in any location that is accessible: @example @@ -400,7 +398,6 @@ installed as @code{emacs} in any location that is accessible: package_name=`pm path org.gnu.emacs 2>/dev/null ;; URL: https://github.com/magit/transient ;; Keywords: extensions -;; Version: 0.7.2 +;; Version: 0.7.2.1 ;; SPDX-License-Identifier: GPL-3.0-or-later diff --git a/lisp/which-key.el b/lisp/which-key.el index 677a84b328d..37b42a009f7 100644 --- a/lisp/which-key.el +++ b/lisp/which-key.el @@ -444,7 +444,7 @@ Note that `which-key-idle-delay' should be set before turning on If non-nil, save window configuration before which-key buffer is shown and restore it after which-key buffer is hidden. It prevents which-key from changing window position of visible -buffers. Only takken into account when popup type is +buffers. Only taken into account when popup type is side-window." :type 'boolean :package-version "1.0" :version "30.1") @@ -2113,7 +2113,7 @@ should be minimized." (defun which-key--create-pages (keys &optional prefix-keys prefix-title) "Create page strings using `which-key--list-to-pages'. Will try to find the best number of rows and columns using the -given dimensions and the length and wdiths of KEYS. SEL-WIN-WIDTH +given dimensions and the length and widths of KEYS. SEL-WIN-WIDTH is the width of the live window." (let* ((max-dims (which-key--popup-max-dimensions)) (max-lines (car max-dims)) @@ -2825,7 +2825,7 @@ Finally, show the buffer." (funcall which-key-this-command-keys-function))))) (cancel-timer which-key--paging-timer) (if which-key-idle-secondary-delay - ;; we haven't executed a command yet so the secandary + ;; we haven't executed a command yet so the secondary ;; timer is more relevant here (which-key--start-timer which-key-idle-secondary-delay t) (which-key--start-timer))))))) diff --git a/src/android-emacs.c b/src/android-emacs.c index d68734da1bd..28b46ca1a4b 100644 --- a/src/android-emacs.c +++ b/src/android-emacs.c @@ -37,7 +37,7 @@ main (int argc, char **argv) { char **args; int i; - char *bootclasspath, *emacs_class_path, *ld_library_path; + char *bootclasspath, *emacs_class_path; /* Allocate enough to hold the arguments to app_process. */ args = alloca ((10 + argc) * sizeof *args); @@ -63,15 +63,6 @@ main (int argc, char **argv) return 1; } - /* Restore LD_LIBRARY_PATH to its original value, the app library - directory, to guarantee that it is possible for Java to find the - Emacs C code later. */ - - ld_library_path = getenv ("EMACS_LD_LIBRARY_PATH"); - - if (ld_library_path) - setenv ("LD_LIBRARY_PATH", ld_library_path, 1); - if (asprintf (&bootclasspath, "-Djava.class.path=%s", emacs_class_path) < 0) { diff --git a/src/android.c b/src/android.c index f90ebc04925..3c96867a6b5 100644 --- a/src/android.c +++ b/src/android.c @@ -1338,7 +1338,7 @@ NATIVE_NAME (setEmacsParams) (JNIEnv *env, jobject object, int pipefd[2]; pthread_t thread; - const char *java_string; + const char *java_string, *tem; struct stat statb; #ifdef THREADS_ENABLED @@ -1491,15 +1491,6 @@ NATIVE_NAME (setEmacsParams) (JNIEnv *env, jobject object, EmacsNoninteractive can be found. */ setenv ("EMACS_CLASS_PATH", android_class_path, 1); - /* Set LD_LIBRARY_PATH to an appropriate value. */ - setenv ("LD_LIBRARY_PATH", android_lib_dir, 1); - - /* EMACS_LD_LIBRARY_PATH records the location of the app library - directory. android-emacs refers to this, since users have valid - reasons for changing LD_LIBRARY_PATH to a value that precludes - the possibility of Java locating libemacs later. */ - setenv ("EMACS_LD_LIBRARY_PATH", android_lib_dir, 1); - /* If the system is Android 5.0 or later, set LANG to en_US.utf8, which is understood by the C library. In other instances set it to C, a meaningless value, for good measure. */