procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

(tab-bar-tests-quit-restore-window): Try and clarify the skip

Browse source 
* test/lisp/tab-bar-tests.el (tab-bar-tests-quit-restore-window):
Rewrite the `skip-unless` based on the code's history because
I found the current code quite confusing.
This commit is contained in:
Stefan Monnier 2025-04-18 09:35:14 -04:00
parent 9f0c43a3d1
commit f5e6f284e9
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
test/lisp/tab-bar-tests.el
View file

@ -52,13 +52,16 @@
(tab-bar-tabs-set nil))
(ert-deftest tab-bar-tests-quit-restore-window ()
;; Emba runs the container without "--tty"
;; (the environment variable "TERM" is nil), and this
;; test fails with '(error "Could not open file: /dev/tty")'.
;; Therefore skip it unless it can use '(tty-type . "linux")'.
(skip-unless (or (and (eq system-type 'gnu/linux) (getenv "TERM"))
(and (not noninteractive)
(eq system-type 'windows-nt))))
(skip-when (pcase system-type
;; Skip test on MS-Windows in batch mode, since terminal
;; frames cannot be created in that case.
('windows-nt noninteractive)
;; Emba runs the container without "--tty"
;; (the environment variable "TERM" is nil), and this
;; test fails with '(error "Could not open file: /dev/tty")'.
;; Therefore skip it unless it can use '(tty-type . "linux")'.
('gnu/linux (null (getenv "TERM")))))
(let* ((frame-params (when noninteractive
'((window-system . nil)
(tty-type . "linux"))))