Handle changed scp protocol in Tramp, don't merge
* lisp/net/tramp-sh.el (tramp-scp-force-scp-protocol): New defvar. (tramp-scp-force-scp-protocol): New defun. (tramp-do-copy-or-rename-file-out-of-band): Use it. (tramp-methods) <scp, scpx>: Use "%y". * lisp/net/tramp.el (tramp-methods): Adapt docstring.
This commit is contained in:
parent
afdf72eeb2
commit
e683b08b3f
2 changed files with 42 additions and 3 deletions
|
@ -134,6 +134,15 @@ be auto-detected by Tramp.
|
|||
|
||||
The string is used in `tramp-methods'.")
|
||||
|
||||
(defvar tramp-scp-force-scp-protocol nil
|
||||
"Force scp protocol.
|
||||
|
||||
It is the string \"-O\" if supported by the local scp (since
|
||||
release 8.6), otherwise the string \"\". If it is nil, it will
|
||||
be auto-detected by Tramp.
|
||||
|
||||
The string is used in `tramp-methods'.")
|
||||
|
||||
;; Initialize `tramp-methods' with the supported methods.
|
||||
;;;###tramp-autoload
|
||||
(tramp--with-startup
|
||||
|
@ -170,7 +179,7 @@ The string is used in `tramp-methods'.")
|
|||
(tramp-remote-shell-args ("-c"))
|
||||
(tramp-copy-program "scp")
|
||||
(tramp-copy-args (("-P" "%p") ("-p" "%k")
|
||||
("%x") ("-q") ("-r") ("%c")))
|
||||
("%x") ("%y") ("-q") ("-r") ("%c")))
|
||||
(tramp-copy-keep-date t)
|
||||
(tramp-copy-recursive t)))
|
||||
(add-to-list 'tramp-methods
|
||||
|
@ -186,7 +195,7 @@ The string is used in `tramp-methods'.")
|
|||
(tramp-remote-shell-args ("-c"))
|
||||
(tramp-copy-program "scp")
|
||||
(tramp-copy-args (("-P" "%p") ("-p" "%k")
|
||||
("%x") ("-q") ("-r") ("%c")))
|
||||
("%x") ("%y") ("-q") ("-r") ("%c")))
|
||||
(tramp-copy-keep-date t)
|
||||
(tramp-copy-recursive t)))
|
||||
(add-to-list 'tramp-methods
|
||||
|
@ -2311,7 +2320,8 @@ The method used must be an out-of-band method."
|
|||
?h (or host "") ?u (or user "") ?p (or port "")
|
||||
?r listener ?c options ?k (if keep-date " " "")
|
||||
?n (concat "2>" (tramp-get-remote-null-device v))
|
||||
?x (tramp-scp-strict-file-name-checking v))
|
||||
?x (tramp-scp-strict-file-name-checking v)
|
||||
?y (tramp-scp-force-scp-protocol v))
|
||||
copy-program (tramp-get-method-parameter v 'tramp-copy-program)
|
||||
copy-keep-date (tramp-get-method-parameter
|
||||
v 'tramp-copy-keep-date)
|
||||
|
@ -4818,6 +4828,33 @@ Goes through the list `tramp-inline-compress-commands'."
|
|||
(setq tramp-scp-strict-file-name-checking "-T")))))))
|
||||
tramp-scp-strict-file-name-checking)))
|
||||
|
||||
(defun tramp-scp-force-scp-protocol (vec)
|
||||
"Return the force scp protocol argument of the local scp."
|
||||
(cond
|
||||
;; No options to be computed.
|
||||
((null (assoc "%y" (tramp-get-method-parameter vec 'tramp-copy-args)))
|
||||
"")
|
||||
|
||||
;; There is already a value to be used.
|
||||
((stringp tramp-scp-force-scp-protocol)
|
||||
tramp-scp-force-scp-protocol)
|
||||
|
||||
;; Determine the options.
|
||||
(t (setq tramp-scp-force-scp-protocol "")
|
||||
(let ((case-fold-search t))
|
||||
(ignore-errors
|
||||
(when (executable-find "scp")
|
||||
(with-tramp-progress-reporter
|
||||
vec 4 "Computing force scp protocol argument"
|
||||
(with-temp-buffer
|
||||
(tramp-call-process vec "scp" nil t nil "-O")
|
||||
(goto-char (point-min))
|
||||
(unless
|
||||
(search-forward-regexp
|
||||
"\\(illegal\\|unknown\\) option -- O" nil t)
|
||||
(setq tramp-scp-force-scp-protocol "-O")))))))
|
||||
tramp-scp-force-scp-protocol)))
|
||||
|
||||
(defun tramp-timeout-session (vec)
|
||||
"Close the connection VEC after a session timeout.
|
||||
If there is just some editing, retry it after 5 seconds."
|
||||
|
|
|
@ -255,6 +255,8 @@ pair of the form (KEY VALUE). The following KEYs are defined:
|
|||
- \"%n\" expands to \"2>/dev/null\".
|
||||
- \"%x\" is replaced by the `tramp-scp-strict-file-name-checking'
|
||||
argument if it is supported.
|
||||
- \"%y\" is replaced by the `tramp-scp-force-scp-protocol'
|
||||
argument if it is supported.
|
||||
|
||||
The existence of `tramp-login-args', combined with the
|
||||
absence of `tramp-copy-args', is an indication that the
|
||||
|
|
Loading…
Add table
Reference in a new issue