procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix unstable proced test

Browse source 
Fix unstable proced test by omitting the revert parameter in
'proced-update'.  This was caused by the process being refined on
exiting between the initial 'proced' call and the successive
'proced-update' call.  This resulted in proced skipping the refinement
in 'proced-update', causing all processes to be shown again and the
test to fail.

* test/lisp/proced-tests.el (proced-refine-with-update-test): Do not
use revert parameter when calling 'proced-update'.
This commit is contained in:
Laurence Warne 2023-05-21 18:59:43 +01:00 • committed by Mattias Engdegård
parent 4289044ccf
commit e6299d2783
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
test/lisp/proced-tests.el
View file

@ -89,14 +89,17 @@
(forward-line)))))
(ert-deftest proced-refine-with-update-test ()
:tags '(:unstable) ; There seems to be an update race here.
(proced--within-buffer
'medium
'user
(proced--move-to-column "PID")
(let ((pid (word-at-point)))
(proced-refine)
(proced-update t)
;; Don't use (proced-update t) since this will reset `proced-process-alist'
;; and it's possible the process refined on would have exited by that
;; point. In this case proced will skip the refinement and show all
;; processes again, causing the test to fail.
(proced-update)
(while (not (eobp))
(proced--move-to-column "PID")
(should (string= pid (word-at-point)))