* lisp/play/fortune.el (fortune-compile): Simplify and fix previous change.
Since file-newer-than-p returns non-nil if FILE2 does not exist, the actual fix for bug#5338 is just a one-liner. But there is no test case or explanation of what the issue actually is in bug#5338, so one has to wonder if the initial (file-exists-p fortune-dat) test was there for a reason...
This commit is contained in:
parent
51b3a99c94
commit
dec2a32292
2 changed files with 12 additions and 11 deletions
|
@ -1,3 +1,7 @@
|
|||
2013-02-15 Glenn Morris <rgm@gnu.org>
|
||||
|
||||
* play/fortune.el (fortune-compile): Simplify and fix previous change.
|
||||
|
||||
2013-02-14 Michael Albinus <michael.albinus@gmx.de>
|
||||
|
||||
* net/tramp.el (tramp-debug-message): Add
|
||||
|
|
|
@ -244,17 +244,14 @@ the value of `fortune-file'. This currently cannot handle directories."
|
|||
(let* ((fortune-file (expand-file-name (substitute-in-file-name file)))
|
||||
(fortune-dat (expand-file-name
|
||||
(substitute-in-file-name
|
||||
(concat fortune-file fortune-database-extension))))
|
||||
(fortune-dat-exist (file-exists-p fortune-dat)))
|
||||
(cond ((file-exists-p fortune-file)
|
||||
(if (or (not fortune-dat-exist)
|
||||
(and fortune-dat-exist
|
||||
(file-newer-than-file-p fortune-file fortune-dat)))
|
||||
(message "Compiling new fortune database %s" fortune-dat)
|
||||
(shell-command
|
||||
(concat fortune-strfile fortune-strfile-options
|
||||
" " fortune-file fortune-quiet-strfile-options))))
|
||||
(t (error "Can't compile fortune file %s" fortune-file)))))
|
||||
(concat fortune-file fortune-database-extension)))))
|
||||
(cond ((file-exists-p fortune-file)
|
||||
(cond ((file-newer-than-file-p fortune-file fortune-dat)
|
||||
(message "Compiling new fortune database %s" fortune-dat)
|
||||
(shell-command
|
||||
(concat fortune-strfile fortune-strfile-options
|
||||
" " fortune-file fortune-quiet-strfile-options)))))
|
||||
(t (error "Can't compile fortune file %s" fortune-file)))))
|
||||
|
||||
|
||||
;;; **************
|
||||
|
|
Loading…
Add table
Reference in a new issue