Fix eww-change-select defaults in a different way

* lisp/net/eww.el (eww-change-select): Fix bug#43218 in a more
safe way than the previous version.
This commit is contained in:
Lars Ingebrigtsen 2020-09-06 02:02:42 +02:00
parent 585fe00557
commit ccd5f0d0a9

View file

@ -1450,14 +1450,13 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
(cons (plist-get (cdr elem) :display)
(plist-get (cdr elem) :value))))
input)))
(display
(completing-read "Change value: " options nil 'require-match
nil nil (car (rassoc (plist-get input :value)
options))))
(display (completing-read "Change value: " options nil 'require-match))
(inhibit-read-only t))
(plist-put input :value (cdr (assoc-string display options t)))
(goto-char
(eww-update-field display))))
;; If the user doesn't enter anything, don't change anything.
(when (> (length display) 0)
(plist-put input :value (cdr (assoc-string display options t)))
(goto-char
(eww-update-field display)))))
(defun eww-update-field (string &optional offset)
(unless offset