text-quoting-style in emacs-lisp diagnostics

* lisp/emacs-lisp/advice.el (ad-read-advised-function)
(ad-read-advice-class, ad-read-advice-name, ad-enable-advice)
(ad-disable-advice, ad-remove-advice, ad-set-argument)
(ad-set-arguments):
* lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand)
(byte-compile-unfold-lambda, byte-optimize-form-code-walker)
(byte-optimize-while, byte-optimize-apply):
* lisp/emacs-lisp/bytecomp.el (byte-compile-lapcode)
(byte-compile-log-file, byte-compile-format-warn)
(byte-compile-nogroup-warn, byte-compile-arglist-warn)
(byte-compile-cl-warn)
(byte-compile-warn-about-unresolved-functions)
(byte-compile-file, byte-compile-fix-header)
(byte-compile--declare-var, byte-compile-file-form-defmumble)
(byte-compile-form, byte-compile-normal-call)
(byte-compile-variable-ref, byte-compile-variable-set)
(byte-compile-subr-wrong-args, byte-compile-setq-default)
(byte-compile-negation-optimizer)
(byte-compile-condition-case--old)
(byte-compile-condition-case--new, byte-compile-save-excursion)
(byte-compile-defvar, byte-compile-autoload)
(byte-compile-lambda-form)
(byte-compile-make-variable-buffer-local, display-call-tree)
(batch-byte-compile):
* lisp/emacs-lisp/cconv.el (cconv-convert, cconv--analyze-use)
(cconv-analyze-form):
* lisp/emacs-lisp/chart.el (chart-space-usage):
* lisp/emacs-lisp/check-declare.el (check-declare-scan)
(check-declare-warn, check-declare-file)
(check-declare-directory):
* lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine)
(checkdoc-message-text-engine):
* lisp/emacs-lisp/cl-extra.el (cl-parse-integer):
* lisp/emacs-lisp/cl-macs.el (cl--parse-loop-clause, cl-tagbody)
(cl-symbol-macrolet):
* lisp/emacs-lisp/cl.el (cl-unload-function, flet):
* lisp/emacs-lisp/copyright.el (copyright)
(copyright-update-directory):
* lisp/emacs-lisp/edebug.el (edebug-read-list):
* lisp/emacs-lisp/eieio-base.el (eieio-persistent-read):
* lisp/emacs-lisp/eieio-core.el (eieio--slot-override)
(eieio-oref, eieio-oset-default):
* lisp/emacs-lisp/eieio-speedbar.el:
(eieio-speedbar-child-make-tag-lines)
(eieio-speedbar-child-description):
* lisp/emacs-lisp/eieio.el (defclass, change-class):
* lisp/emacs-lisp/elint.el (elint-file, elint-get-top-forms)
(elint-init-form, elint-check-defalias-form)
(elint-check-let-form):
* lisp/emacs-lisp/ert.el (ert-get-test):
* lisp/emacs-lisp/find-func.el (find-function-search-for-symbol)
(find-function-library):
* lisp/emacs-lisp/generator.el (iter-yield):
* lisp/emacs-lisp/gv.el (gv-define-simple-setter):
* lisp/emacs-lisp/lisp-mnt.el (lm-verify):
* lisp/emacs-lisp/package-x.el (package-upload-file):
* lisp/emacs-lisp/package.el (package-version-join)
(package-disabled-p, package-activate-1, package-activate)
(package--download-one-archive)
(package--download-and-read-archives)
(package-compute-transaction, package-install-from-archive)
(package-install, package-install-selected-packages)
(package-delete, package-autoremove)
(package-install-button-action, package-delete-button-action)
(package-menu-hide-package, package-menu--list-to-prompt)
(package-menu--perform-transaction)
(package-menu--find-and-notify-upgrades):
* lisp/emacs-lisp/pcase.el (pcase-exhaustive, pcase--u1):
* lisp/emacs-lisp/re-builder.el (reb-enter-subexp-mode):
* lisp/emacs-lisp/ring.el (ring-next, ring-previous):
* lisp/emacs-lisp/rx.el (rx-check, rx-anything):
* lisp/emacs-lisp/smie.el (smie-config-save):
* lisp/emacs-lisp/subr-x.el (internal--check-binding):
* lisp/emacs-lisp/testcover.el (testcover-1value):
Use curved quotes in diagnostic format strings.

lisp/emacs-lisp/checkdoc.el

@@ -1663,7 +1663,7 @@ function,command,variable,option or symbol." ms1))))))
 	     ;;    	  (concat "\\<" (regexp-quote (car fp)) "\\>")
 	     ;;    	  newname))
 	     ;;         (checkdoc-create-error
-	     ;;          "Flag variable names should normally end in `-flag'" s
+	     ;;          "Flag variable names should normally end in ‘-flag’" s
 	     ;;          (marker-position e)))))
 	     ;; Done with variables
 	     ))
@@ -1715,7 +1715,7 @@ function,command,variable,option or symbol." ms1))))))
 			     (if (checkdoc-autofix-ask-replace
 				  (match-beginning 1) (match-end 1)
 				  (format
-				   "If this is the argument `%s', it should appear as %s.  Fix? "
+				   "If this is the argument ‘%s’, it should appear as %s.  Fix? "
 				   (car args) (upcase (car args)))
 				  (upcase (car args)) t)
 				 (setq found (match-beginning 1))))))
@@ -1741,7 +1741,7 @@ function,command,variable,option or symbol." ms1))))))
 			 nil)
 		     (checkdoc-create-error
 		      (format
-		       "Argument `%s' should appear (as %s) in the doc string"
+		       "Argument ‘%s’ should appear (as %s) in the doc string"
 		       (car args) (upcase (car args)))
 		      s (marker-position e)))
 		 (if (or (and order (eq order 'yes))
@@ -1824,7 +1824,7 @@ Replace with \"%s\"? " original replace)
 		    (setq found (intern-soft ms))
 		    (or (boundp found) (fboundp found)))
 	       (progn
-		 (setq msg (format "Add quotes around Lisp symbol `%s'? "
+		 (setq msg (format "Add quotes around Lisp symbol ‘%s’? "
 				   ms))
 		 (if (checkdoc-autofix-ask-replace
 		      (match-beginning 1) (+ (match-beginning 1)
@@ -1832,7 +1832,7 @@ Replace with \"%s\"? " original replace)
 		      msg (concat "‘" ms "’") t)
 		     (setq msg nil)
 		   (setq msg
-			 (format "Lisp symbol `%s' should appear in quotes"
+			 (format "Lisp symbol ‘%s’ should appear in quotes"
 				 ms))))))
 	 (if msg
 	     (checkdoc-create-error msg (match-beginning 1)
@@ -1849,7 +1849,7 @@ Replace with \"%s\"? " original replace)
 		(match-string 2) t)
 	       nil
 	     (checkdoc-create-error
-	      "Symbols t and nil should not appear in `...' quotes"
+	      "Symbols t and nil should not appear in ‘...’ quotes"
 	      (match-beginning 1) (match-end 1)))))
      ;; Here is some basic sentence formatting
      (checkdoc-sentencespace-region-engine (point) e)
@@ -2487,22 +2487,22 @@ Argument TYPE specifies the type of question, such as `error' or `y-or-n-p'."
 	       ;; If we see a ?, then replace with "? ".
 	       (if (checkdoc-autofix-ask-replace
 		    (match-beginning 0) (match-end 0)
-		    "`y-or-n-p' argument should end with \"? \".  Fix? "
+		    "‘y-or-n-p’ argument should end with \"? \".  Fix? "
 		    "? " t)
 		   nil
 		 (checkdoc-create-error
-		  "`y-or-n-p' argument should end with \"? \""
+		  "‘y-or-n-p’ argument should end with \"? \""
 		  (match-beginning 0) (match-end 0)))
 	     (if (save-excursion (forward-sexp 1)
 				 (forward-char -2)
 				 (looking-at " "))
 		 (if (checkdoc-autofix-ask-replace
 		      (match-beginning 0) (match-end 0)
-		      "`y-or-n-p' argument should end with \"? \".  Fix? "
+		      "‘y-or-n-p’ argument should end with \"? \".  Fix? "
 		      "? " t)
 		     nil
 		   (checkdoc-create-error
-		    "`y-or-n-p' argument should end with \"? \""
+		    "‘y-or-n-p’ argument should end with \"? \""
 		    (match-beginning 0) (match-end 0)))
 	       (if (and ;; if this isn't true, we have a problem.
 		    (save-excursion (forward-sexp 1)
@@ -2510,11 +2510,11 @@ Argument TYPE specifies the type of question, such as `error' or `y-or-n-p'."
 				    (looking-at "\""))
 		    (checkdoc-autofix-ask-replace
 		     (match-beginning 0) (match-end 0)
-		     "`y-or-n-p' argument should end with \"? \".  Fix? "
+		     "‘y-or-n-p’ argument should end with \"? \".  Fix? "
 		     "? \"" t))
 		   nil
 		 (checkdoc-create-error
-		  "`y-or-n-p' argument should end with \"? \""
+		  "‘y-or-n-p’ argument should end with \"? \""
 		  (match-beginning 0) (match-end 0)))))))
      ;; Now, let's just run the spell checker on this guy.
      (checkdoc-ispell-docstring-engine (save-excursion (forward-sexp 1)