Use lexical-binding in sasl.el and add tests

* lisp/net/sasl.el:
* lisp/net/sasl-digest.el:
* lisp/net/sasl-cram.el:
* lisp/net/sasl-ntlm.el: Use lexical-binding.

* test/lisp/net/sasl-tests.el:
* test/lisp/net/sasl-cram-tests.el: New files.
This commit is contained in:
Stefan Kangas 2021-01-29 20:11:38 +01:00
parent e86b30d6fd
commit c7a86cb7ec
6 changed files with 109 additions and 4 deletions

View file

@ -1,4 +1,4 @@
;;; sasl-cram.el --- CRAM-MD5 module for the SASL client framework
;;; sasl-cram.el --- CRAM-MD5 module for the SASL client framework -*- lexical-binding: t -*-
;; Copyright (C) 2000, 2007-2021 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; sasl-digest.el --- DIGEST-MD5 module for the SASL client framework
;;; sasl-digest.el --- DIGEST-MD5 module for the SASL client framework -*- lexical-binding: t -*-
;; Copyright (C) 2000, 2007-2021 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; sasl-ntlm.el --- NTLM (NT Lan Manager) module for the SASL client framework
;;; sasl-ntlm.el --- NTLM (NT Lan Manager) module for the SASL client framework -*- lexical-binding: t -*-
;; Copyright (C) 2000, 2007-2021 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; sasl.el --- SASL client framework
;;; sasl.el --- SASL client framework -*- lexical-binding: t -*-
;; Copyright (C) 2000, 2007-2021 Free Software Foundation, Inc.

View file

@ -0,0 +1,46 @@
;;; sasl-cram-tests.el --- tests for sasl-cram.el -*- lexical-binding: t; -*-
;; Copyright (C) 2021 Free Software Foundation, Inc.
;; Author: Stefan Kangas <stefankangas@gmail.com>
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
;;; Commentary:
;; Test case from RFC 2195.
;;; Code:
(require 'ert)
(require 'sasl)
(require 'sasl-cram)
(ert-deftest sasl-cram-md5-response-test ()
;; The following strings are taken from section 2 of RFC 2195.
(let ((client
(sasl-make-client (sasl-find-mechanism '("CRAM-MD5"))
"user"
"imap"
"localhost"))
(data (base64-decode-string "PDE4OTYuNjk3MTcwOTUyQHBvc3RvZmZpY2UucmVzdG9uLm1jaS5uZXQ+"))
(sasl-read-passphrase
(lambda (_prompt) (copy-sequence "tanstaaftanstaaf"))))
(should (equal (sasl-cram-md5-response client (vector nil data))
"user b913a602c7eda7a495b4e6e7334d3890"))))
(provide 'sasl-cram-tests)
;;; sasl-cram-tests.el ends here

View file

@ -0,0 +1,59 @@
;;; sasl-tests.el --- tests for sasl.el -*- lexical-binding: t; -*-
;; Copyright (C) 2021 Free Software Foundation, Inc.
;; Author: Stefan Kangas <stefankangas@gmail.com>
;; This file is part of GNU Emacs.
;; GNU Emacs is free software: you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; GNU Emacs is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
;; along with GNU Emacs. If not, see <https://www.gnu.org/licenses/>.
;;; Commentary:
;;; Code:
(require 'ert)
(require 'sasl)
(ert-deftest sasl-test-make-client ()
(let ((client (sasl-make-client 'foo 'bar 'baz 'zut)))
(should (eq (sasl-client-mechanism client) 'foo))
(should (eq (sasl-client-name client) 'bar))
(should (eq (sasl-client-service client) 'baz))
(should (eq (sasl-client-server client) 'zut))))
(ert-deftest sasl-test-client-set-properties ()
(let ((client (sasl-make-client 'foo 'bar 'baz 'zut)))
(sasl-client-set-property client 'foo 'bar)
(should (eq (sasl-client-property client 'foo) 'bar))))
(ert-deftest sasl-test-step-data ()
(let ((step [nil nil]))
(sasl-step-set-data step "foo")
(should (equal (sasl-step-data step) "foo"))))
(ert-deftest sasl-test-unique-id ()
(should (stringp (sasl-unique-id)))
(should-not (equal (sasl-unique-id) (sasl-unique-id))))
(ert-deftest sasl-test-find-mechanism ()
(should (sasl-find-mechanism '("ANONYMOUS")))
(should-not (sasl-find-mechanism '("nonexistent mechanism"))))
(ert-deftest sasl-test-mechanism-name ()
(let ((mechanism (sasl-find-mechanism '("ANONYMOUS"))))
(should (equal (sasl-mechanism-name mechanism) "ANONYMOUS"))))
(provide 'sasl-tests)
;;; sasl-tests.el ends here