Fix crash when windows are destroyed by faulty clients

* src/xterm.c (x_dnd_compute_toplevels): Make sure
property_reply is non-NULL before testing its format and length.
This commit is contained in:
Po Lu 2022-03-26 12:20:23 +08:00
parent 98952340bd
commit c16b296939

View file

@ -1025,8 +1025,9 @@ x_dnd_compute_toplevels (struct x_display_info *dpyinfo)
free (error);
}
if (xcb_get_property_value_length (property_reply) != 8
|| property_reply->format != 32)
if (property_reply
&& (xcb_get_property_value_length (property_reply) != 8
|| property_reply->format != 32))
rc = false;
geometry_reply = xcb_get_geometry_reply (dpyinfo->xcb_connection,