procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid undefined behavior with botched pgtk menu

Browse source 
* src/pgtkmenu.c (pgtk_menu_show): Do not dereference save_wv if
null.  Problem found by gcc 20250110 (Red Hat 14.2.1-7)
-Wanalyzer-null-dereference.
This commit is contained in:
Paul Eggert 2025-01-26 22:15:49 -08:00
parent 06fd3f4e98
commit c0d83876f1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/pgtkmenu.c
View file

@ -725,7 +725,7 @@ pgtk_menu_show (struct frame *f, int x, int y, int menuflags,
STRINGP (help) ? help : Qnil);
if (prev_wv)
prev_wv->next = wv;
else
else if (save_wv)
save_wv->contents = wv;
if (!NILP (descrip))
wv->key = SSDATA (descrip);