procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix url-copy-file arglist

Browse source 
* lisp/url/url-handlers.el: Silence byte-compiler.
(url-copy-file): Add 6th argument following change to copy-file in
2012-12-16T19:22:27+01:00!romain@orebokech.com. (bug#4410)
This commit is contained in:
Basil L. Contovounesios 2019-03-19 16:00:18 +00:00
parent eaa188a6a0
commit bd5795e0d1
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lisp/url/url-handlers.el
View file

@ -41,6 +41,9 @@
(declare-function mm-decode-string "mm-bodies" (string charset)) (declare-function mm-decode-string "mm-bodies" (string charset))
;; mm-decode loads mail-parse. ;; mm-decode loads mail-parse.
(declare-function mail-content-type-get "mail-parse" (ct attribute)) (declare-function mail-content-type-get "mail-parse" (ct attribute))
;; mm-bodies loads mm-util.
(declare-function mm-charset-to-coding-system "mm-util"
(charset &optional lbt allow-override silent))
;; Implementation status ;; Implementation status
;; --------------------- ;; ---------------------
@ -250,15 +253,15 @@ the arguments that would have been passed to OPERATION."
;; The actual implementation ;; The actual implementation
;;;###autoload ;;;###autoload
(defun url-copy-file (url newname &optional ok-if-already-exists (defun url-copy-file (url newname &optional ok-if-already-exists
_keep-time _preserve-uid-gid) _keep-time _preserve-uid-gid _preserve-permissions)
"Copy URL to NEWNAME. Both args must be strings. "Copy URL to NEWNAME. Both args must be strings.
Signals a `file-already-exists' error if file NEWNAME already exists, Signal a `file-already-exists' error if file NEWNAME already exists,
unless a third argument OK-IF-ALREADY-EXISTS is supplied and non-nil. unless a third argument OK-IF-ALREADY-EXISTS is supplied and non-nil.
A number as third arg means request confirmation if NEWNAME already exists. A number as third arg means request confirmation if NEWNAME already exists.
This is what happens in interactive use with M-x. This is what happens in interactive use with M-x.
Fourth arg KEEP-TIME non-nil means give the new file the same Fourth arg KEEP-TIME non-nil means give the new file the same
last-modified time as the old one. (This works on only some systems.) last-modified time as the old one. (This works on only some systems.)
Fifth arg PRESERVE-UID-GID is ignored. Args PRESERVE-UID-GID and PRESERVE-PERMISSIONS are ignored.
A prefix arg makes KEEP-TIME non-nil." A prefix arg makes KEEP-TIME non-nil."
(if (and (file-exists-p newname) (if (and (file-exists-p newname)
(not ok-if-already-exists)) (not ok-if-already-exists))
@ -341,7 +344,7 @@ if it had been inserted from a file named URL."
(unless buffer (signal 'file-error (list url "No Data"))) (unless buffer (signal 'file-error (list url "No Data")))
(with-current-buffer buffer (with-current-buffer buffer
;; XXX: This is HTTP/S specific and should be moved to url-http ;; XXX: This is HTTP/S specific and should be moved to url-http
;; instead. See https://debbugs.gnu.org/17549. ;; instead. See bug#17549.
(when (bound-and-true-p url-http-response-status) (when (bound-and-true-p url-http-response-status)
;; Don't signal an error if VISIT is non-nil, because ;; Don't signal an error if VISIT is non-nil, because
;; 'insert-file-contents' doesn't. This is required to ;; 'insert-file-contents' doesn't. This is required to
@ -354,7 +357,7 @@ if it had been inserted from a file named URL."
(< url-http-response-status 300))) (< url-http-response-status 300)))
(let ((desc (nth 2 (assq url-http-response-status url-http-codes)))) (let ((desc (nth 2 (assq url-http-response-status url-http-codes))))
(kill-buffer buffer) (kill-buffer buffer)
;; Signal file-error per https://debbugs.gnu.org/16733. ;; Signal file-error per bug#16733.
(signal 'file-error (list url desc)))))) (signal 'file-error (list url desc))))))
(url-insert-buffer-contents buffer url visit beg end replace))) (url-insert-buffer-contents buffer url visit beg end replace)))