procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove extraneous calls to shell-quote-argument

Browse source
This commit is contained in:
Karl Berry 2005-05-28 16:57:21 +00:00
parent 8164904190
commit b5352ff5ec
2 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lisp/ChangeLog
View file

@ -1,3 +1,11 @@
2005-05-28 Karl Berry <karl@gnu.org>
* textmodes/tex-mode.el: now that tex-send-command calls
shell-quote-argument (2005-03-31 change), remove all calls to
shell-quote-argument; they all end up invoking tex-send-command.
The double quoting loses on filenames with non-safe characters,
such as "@". Reported by Frederik Fouvry.
2005-05-29 Nick Roberts <nickrob@snap.net.nz> 2005-05-29 Nick Roberts <nickrob@snap.net.nz>
* progmodes/gdb-ui.el (gdb-assembler-custom): Be more careful * progmodes/gdb-ui.el (gdb-assembler-custom): Be more careful
@ -3106,11 +3114,6 @@
(fill-newline): Use fill-text-properties-at instead of (fill-newline): Use fill-text-properties-at instead of
text-properties-at. text-properties-at.
2005-03-31 Karl Berry <karl@freefriends.org>
* textmodes/tex-mode.el (tex-compile): Use shell-quote-argument,
not comint-quote-filename.
2005-03-31 Olive Lin <olive.lin@versateladsl.be> (tiny change) 2005-03-31 Olive Lin <olive.lin@versateladsl.be> (tiny change)
* textmodes/tex-mode.el (tex-start-tex) Use shell-quote-argument, * textmodes/tex-mode.el (tex-start-tex) Use shell-quote-argument,

18
lisp/textmodes/tex-mode.el
View file

@ -1633,11 +1633,11 @@ If NOT-ALL is non-nil, save the `.dvi' file."
(defvar tex-compile-commands (defvar tex-compile-commands
'(((concat "pdf" tex-command '(((concat "pdf" tex-command
" " (if (< 0 (length tex-start-commands)) " " (if (< 0 (length tex-start-commands))
(shell-quote-argument tex-start-commands)) " %f") tex-start-commands) " %f")
t "%r.pdf") t "%r.pdf")
((concat tex-command ((concat tex-command
" " (if (< 0 (length tex-start-commands)) " " (if (< 0 (length tex-start-commands))
(shell-quote-argument tex-start-commands)) " %f") tex-start-commands) " %f")
t "%r.dvi") t "%r.dvi")
("yap %r &" "%r.dvi") ("yap %r &" "%r.dvi")
("xdvi %r &" "%r.dvi") ("xdvi %r &" "%r.dvi")
@ -1900,8 +1900,8 @@ FILE is typically the output DVI or PDF file."
(prog1 (file-name-directory (expand-file-name file)) (prog1 (file-name-directory (expand-file-name file))
(setq file (file-name-nondirectory file)))) (setq file (file-name-nondirectory file))))
(root (file-name-sans-extension file)) (root (file-name-sans-extension file))
(fspec (list (cons ?r (shell-quote-argument root)) (fspec (list (cons ?r root)
(cons ?f (shell-quote-argument file)))) (cons ?f file)))
(default (tex-compile-default fspec))) (default (tex-compile-default fspec)))
(list default-directory (list default-directory
(completing-read (completing-read
@ -1922,14 +1922,13 @@ FILE is typically the output DVI or PDF file."
(compile-command (compile-command
(if star (if star
(concat (substring command 0 star) (concat (substring command 0 star)
(shell-quote-argument file) file
(substring command (1+ star))) (substring command (1+ star)))
(concat command " " (concat command " "
tex-start-options tex-start-options
(if (< 0 (length tex-start-commands)) (if (< 0 (length tex-start-commands))
(concat (concat tex-start-commands " "))
(shell-quote-argument tex-start-commands) " ")) file))))
(shell-quote-argument file)))))
(tex-send-tex-command compile-command dir))) (tex-send-tex-command compile-command dir)))
(defun tex-send-tex-command (cmd &optional dir) (defun tex-send-tex-command (cmd &optional dir)
@ -2232,8 +2231,7 @@ is provided, use the alternative command, `tex-alt-dvi-print-command'."
(tex-start-shell)) (tex-start-shell))
(tex-send-command (tex-send-command
(if alt tex-alt-dvi-print-command tex-dvi-print-command) (if alt tex-alt-dvi-print-command tex-dvi-print-command)
(shell-quote-argument print-file-name-dvi
print-file-name-dvi)
t)))) t))))
(defun tex-alt-print () (defun tex-alt-print ()