Fix history adding in ido-read-internal

Assume, for example, the head of matches is "RSS" and user input is
"rs". If the user hit RET, "RSS" is selected but "rs" is added to the
history. This commit fixes this inconsistency.
This commit is contained in:
Leo Liu 2011-03-22 01:48:36 +08:00
parent 78f64af0ae
commit af896da66a
2 changed files with 9 additions and 1 deletions

View file

@ -1,3 +1,8 @@
2011-03-21 Leo Liu <sdl.web@gmail.com>
* ido.el (ido-read-internal): Add ido-selected to history instead
of user input.
2011-03-21 Stefan Monnier <monnier@iro.umontreal.ca>
* subr.el (deferred-action-list, deferred-action-function):

View file

@ -1978,7 +1978,9 @@ If INITIAL is non-nil, it specifies the initial input string."
(ido-completing-read t)
(ido-require-match require-match)
(ido-use-mycompletion-depth (1+ (minibuffer-depth)))
(show-paren-mode nil))
(show-paren-mode nil)
;; Postpone history adding till later
(history-add-new-input nil))
;; prompt the user for the file name
(setq ido-exit nil)
(setq ido-final-text
@ -2158,6 +2160,7 @@ If INITIAL is non-nil, it specifies the initial input string."
(t
(setq done t))))))
(and history (add-to-history history ido-selected))
ido-selected))
(defun ido-edit-input ()