From a73e4f53ab86c69fdb8f5869173d6693d73e6fb2 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 26 May 2018 16:42:52 -0700 Subject: [PATCH] GNOME moved URLs for its active bug reports * src/emacs.c (main) [USE_GTK]: * src/gtkutil.c (xg_display_close): * src/xterm.c (x_connection_closed): Update GNOME bug report URLs. --- admin/notes/multi-tty | 2 +- configure.ac | 2 +- etc/PROBLEMS | 4 ++-- src/emacs.c | 2 +- src/gtkutil.c | 4 ++-- src/image.c | 2 +- src/xterm.c | 4 ++-- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/admin/notes/multi-tty b/admin/notes/multi-tty index 9cfe7aacd35..5b34bb598ef 100644 --- a/admin/notes/multi-tty +++ b/admin/notes/multi-tty @@ -305,7 +305,7 @@ THINGS TO DO multidisplay (and don't mind core dumps), you can edit src/config.h and define HAVE_GTK_MULTIDISPLAY there by hand. - http://bugzilla.gnome.org/show_bug.cgi?id=85715 + https://gitlab.gnome.org/GNOME/gtk/issues/221 Update: Han reports that GTK+ version 2.8.9 almost gets display disconnects right. GTK will probably be fully fixed by the time diff --git a/configure.ac b/configure.ac index a49b7727975..a11abc1b65b 100644 --- a/configure.ac +++ b/configure.ac @@ -2684,7 +2684,7 @@ if test x"$pkg_check_gtk" = xyes; then closing open displays. This is no problem if you just use one display, but if you use more than one and close one of them Emacs may crash. - See https://bugzilla.gnome.org/show_bug.cgi?id=85715]]) + See https://gitlab.gnome.org/GNOME/gtk/issues/221]]) fi fi diff --git a/etc/PROBLEMS b/etc/PROBLEMS index d42539061be..fe48febfb78 100644 --- a/etc/PROBLEMS +++ b/etc/PROBLEMS @@ -207,7 +207,7 @@ configuring your compiler to use the native linker instead of GNU ld. ** When Emacs is compiled with Gtk+, closing a display kills Emacs. There is a long-standing bug in GTK that prevents it from recovering -from disconnects: http://bugzilla.gnome.org/show_bug.cgi?id=85715. +from disconnects: https://gitlab.gnome.org/GNOME/gtk/issues/221 Thus, for instance, when Emacs is run as a server on a text terminal, and an X frame is created, and the X server for that frame crashes or @@ -225,7 +225,7 @@ The error message is: X protocol error: BadMatch (invalid parameter attributes) on protocol request 140 When compiled with GTK, Emacs cannot recover from X disconnects. - This is a GTK bug: https://bugzilla.gnome.org/show_bug.cgi?id=85715 + This is a GTK bug: https://gitlab.gnome.org/GNOME/gtk/issues/221 For details, see etc/PROBLEMS. Fatal error 6: Aborted diff --git a/src/emacs.c b/src/emacs.c index f25e6126642..8633e934e51 100644 --- a/src/emacs.c +++ b/src/emacs.c @@ -1070,7 +1070,7 @@ main (int argc, char **argv) #endif /* HAVE_LIBSYSTEMD */ #ifdef USE_GTK - fprintf (stderr, "\nWarning: due to a long standing Gtk+ bug\nhttp://bugzilla.gnome.org/show_bug.cgi?id=85715\n\ + fprintf (stderr, "\nWarning: due to a long standing Gtk+ bug\nhttps://gitlab.gnome.org/GNOME/gtk/issues/221\n\ Emacs might crash when run in daemon mode and the X11 connection is unexpectedly lost.\n\ Using an Emacs configured with --with-x-toolkit=lucid does not have this problem.\n"); #endif /* USE_GTK */ diff --git a/src/gtkutil.c b/src/gtkutil.c index 3f21288f461..8cc523649d9 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -258,8 +258,8 @@ xg_display_close (Display *dpy) } #if GTK_CHECK_VERSION (2, 0, 0) && ! GTK_CHECK_VERSION (2, 10, 0) - /* GTK 2.2-2.8 has a bug that makes gdk_display_close crash (bug - http://bugzilla.gnome.org/show_bug.cgi?id=85715). This way we + /* GTK 2.2-2.8 has a bug that makes gdk_display_close crash + . This way we can continue running, but there will be memory leaks. */ g_object_run_dispose (G_OBJECT (gdpy)); #else diff --git a/src/image.c b/src/image.c index 4d5a1bf5e66..992b225d7b7 100644 --- a/src/image.c +++ b/src/image.c @@ -9302,7 +9302,7 @@ svg_load_image (struct frame *f, struct image *img, char *contents, /* Set base_uri for properly handling referenced images (via 'href'). See rsvg bug 596114 - "image refs are relative to curdir, not .svg file" - (https://bugzilla.gnome.org/show_bug.cgi?id=596114). */ + . */ if (filename) rsvg_handle_set_base_uri(rsvg_handle, filename); diff --git a/src/xterm.c b/src/xterm.c index 3f956d950d8..4bdec7134f4 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -9828,13 +9828,13 @@ x_connection_closed (Display *dpy, const char *error_message, bool ioerror) current Xt versions, this isn't needed either. */ #ifdef USE_GTK /* A long-standing GTK bug prevents proper disconnect handling - (https://bugzilla.gnome.org/show_bug.cgi?id=85715). Once, + . Once, the resulting Glib error message loop filled a user's disk. To avoid this, kill Emacs unconditionally on disconnect. */ shut_down_emacs (0, Qnil); fprintf (stderr, "%s\n\ When compiled with GTK, Emacs cannot recover from X disconnects.\n\ -This is a GTK bug: https://bugzilla.gnome.org/show_bug.cgi?id=85715\n\ +This is a GTK bug: https://gitlab.gnome.org/GNOME/gtk/issues/221\n\ For details, see etc/PROBLEMS.\n", error_msg); emacs_abort ();