Fix Flymake help-echo functions across windows (bug#29142)

* lisp/progmodes/flymake.el (flymake--highlight-line): Use
with-selected-window.
(flymake-goto-next-error): Call help-echo with a window and an
overlay.
This commit is contained in:
João Távora 2017-11-05 14:58:07 +00:00
parent 58bb3462ee
commit a2cc6d74c5

View file

@ -520,11 +520,12 @@ associated `flymake-category' return DEFAULT."
(flymake--fringe-overlay-spec
(overlay-get ov 'bitmap)))
(default-maybe 'help-echo
(lambda (_window _ov pos)
(mapconcat
#'flymake--diag-text
(flymake-diagnostics pos)
"\n")))
(lambda (window _ov pos)
(with-selected-window window
(mapconcat
#'flymake--diag-text
(flymake-diagnostics pos)
"\n"))))
(default-maybe 'severity (warning-numeric-level :error))
(default-maybe 'priority (+ 100 (overlay-get ov 'severity))))
;; Some properties can't be overridden.
@ -949,7 +950,7 @@ applied."
(message
"%s"
(funcall (overlay-get target 'help-echo)
nil nil (point)))))
(selected-window) target (point)))))
(interactive
(user-error "No more Flymake errors%s"
(if filter