procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Tweak recent additions in tabify-tests.el

Browse source 
* test/lisp/tabify-tests.el (tabify-tests--test-changes): Rename
third argument to avoid "lexical argument shadows dynamic variable"
warnings.  Use mapconcat in place of mapcar+concat.
(tabify-tests-untabify, tabify-tests-tabify): Quote function symbols
as such.
This commit is contained in:
Basil L. Contovounesios 2019-05-26 11:23:03 +01:00
parent a51ab2f357
commit 9fe3bdf25d
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
test/lisp/tabify-tests.el
View file

@ -24,12 +24,12 @@
(require 'ert)
(require 'tabify)
(defun tabify-tests--test-changes (fun changes tab-width)
(defun tabify-tests--test-changes (fun changes width)
(with-temp-buffer
(let ((tab-width tab-width))
(insert (apply 'concat (mapcar 'car changes)))
(let ((tab-width width))
(insert (mapconcat #'car changes ""))
(funcall fun (point-min) (point-max))
(should (equal (buffer-string) (apply 'concat (mapcar 'cadr changes)))))))
(should (equal (buffer-string) (mapconcat #'cadr changes ""))))))
(ert-deftest tabify-tests-untabify ()
(let ((changes '(("***\n" "***\n")
@ -44,7 +44,7 @@
(" \t ***\n" " ***\n")
(" \t***\n" " ***\n")
(" \t***\n" " ***\n"))))
(tabify-tests--test-changes 'untabify changes 2)))
(tabify-tests--test-changes #'untabify changes 2)))
(ert-deftest tabify-tests-tabify ()
(let ((changes '(("***\n" "***\n")
@ -58,7 +58,7 @@
("\t***\n" "\t***\n")
("\t ***\n" "\t ***\n")
("\t\t***\n" "\t\t***\n"))))
(tabify-tests--test-changes 'tabify changes 2)))
(tabify-tests--test-changes #'tabify changes 2)))
(ert-deftest tabify-tests-tabify/all-spaces-on-line ()
(with-temp-buffer