From 9eea6be5abffa91d21ea299158d5a2cd6cfb5089 Mon Sep 17 00:00:00 2001 From: Konstantin Kharlamov Date: Tue, 25 Jun 2024 12:26:12 +0300 Subject: [PATCH] Don't produce invalid XML with multi-line commenting style Both XML and HTML forbid double hyphens inside comments. However, nxml-mode was using a `!--' as a comment padding if `comment-style' was set to any of the styles that supposed to add padding. This infix was auto-derived due to `comment-continue' being nil. To fix that set `comment-continue' explicitly. It's unclear what padding should be used, but from looking at other editors it seems they don't typically add padding in XML, so let's be simple for now and just set `comment-continue' to empty string. * lisp/nxml/nxml-mode.el (nxml-mode): Make 'comment-continue' a buffer-local variable set to the empty string. (Bug#71772) --- lisp/nxml/nxml-mode.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/nxml/nxml-mode.el b/lisp/nxml/nxml-mode.el index 02391dc6968..a58d3f3c75f 100644 --- a/lisp/nxml/nxml-mode.el +++ b/lisp/nxml/nxml-mode.el @@ -531,6 +531,7 @@ Many aspects this mode can be customized using (setq-local comment-end-skip "[ \t\r\n]*-->") (setq-local comment-line-break-function #'nxml-newline-and-indent) (setq-local comment-quote-nested-function #'nxml-comment-quote-nested) + (setq-local comment-continue "") ; avoid double-hyphens as a padding (save-excursion (save-restriction (widen)