procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* Warn when certain primitives are redefined (bug#61880)

Browse source 
* lisp/emacs-lisp/comp.el (comp-warn-primitives): New constant.
	(comp-subr-trampoline-install): Warn when a sensitive primitive is
	being redefined.
This commit is contained in:
Andrea Corallo 2023-03-05 10:46:18 +01:00
parent 5af695c747
commit 9c18af0cfa
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lisp/emacs-lisp/comp.el
View file

@ -698,11 +698,22 @@ Useful to hook into pass checkers.")
(defvar comp-no-spawn nil (defvar comp-no-spawn nil
"Non-nil don't spawn native compilation processes.") "Non-nil don't spawn native compilation processes.")
(defconst comp-warn-primitives
'(null memq gethash and subrp not subr-native-elisp-p
comp--install-trampoline concat if symbolp symbol-name make-string
length aset aref length> mapcar expand-file-name
file-name-as-directory file-exists-p native-elisp-load)
"List of primitives we want to warn about in case of redefinition.
This are essential for the trampoline machinery to work properly.")
;; Moved early to avoid circularity when comp.el is loaded and ;; Moved early to avoid circularity when comp.el is loaded and
;; `macroexpand' needs to be advised (bug#47049). ;; `macroexpand' needs to be advised (bug#47049).
;;;###autoload ;;;###autoload
(defun comp-subr-trampoline-install (subr-name) (defun comp-subr-trampoline-install (subr-name)
"Make SUBR-NAME effectively advice-able when called from native code." "Make SUBR-NAME effectively advice-able when called from native code."
(when (memq subr-name comp-warn-primitives)
(warn "Redefining `%s' might breaks trampoline native compilation."
subr-name))
(unless (or (null native-comp-enable-subr-trampolines) (unless (or (null native-comp-enable-subr-trampolines)
(memq subr-name native-comp-never-optimize-functions) (memq subr-name native-comp-never-optimize-functions)
(gethash subr-name comp-installed-trampolines-h)) (gethash subr-name comp-installed-trampolines-h))