procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove duplicated tests in checkdoc-tests.el

Browse source 
* test/lisp/emacs-lisp/checkdoc-tests.el (checkdoc-cl-defmethod-ok)
(checkdoc-cl-defmethod-with-types-ok, checkdoc-cl-defun-with-key-ok)
(checkdoc-cl-defun-with-allow-other-keys-ok)
(checkdoc-cl-defun-with-default-optional-value-ok)
(checkdoc-cl-defun-with-destructuring-ok): This tests were duplicated,
so keep one copy of them.  Checked by diffing two files with the
suspected tests, and supported by the fact that running occur with the
regexp "^(ert-deftest" reported 14 matches, while the tests being run
were 8.
This commit is contained in:
Mauro Aranda 2021-03-04 10:13:26 -03:00
parent 7b99fc0069
commit 986bf7ac0d
1 changed files with 0 additions and 45 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
test/lisp/emacs-lisp/checkdoc-tests.el
View file

@ -82,51 +82,6 @@
(insert "(cl-defun foo ((a b &optional c) d) \"Return A+B+C+D.\")")
(checkdoc-defun)))
(ert-deftest checkdoc-cl-defmethod-ok ()
"Checkdoc should be happy with a simple correct cl-defmethod."
(with-temp-buffer
(emacs-lisp-mode)
(insert "(cl-defmethod foo (a) \"Return A.\")")
(checkdoc-defun)))
(ert-deftest checkdoc-cl-defmethod-with-types-ok ()
"Checkdoc should be happy with a cl-defmethod using types."
(with-temp-buffer
(emacs-lisp-mode)
;; this method matches if A is the symbol `smthg' and if b is a list:
(insert "(cl-defmethod foo ((a (eql smthg)) (b list)) \"Return A+B.\")")
(checkdoc-defun)))
(ert-deftest checkdoc-cl-defun-with-key-ok ()
"Checkdoc should be happy with a cl-defun using &key."
(with-temp-buffer
(emacs-lisp-mode)
(insert "(cl-defun foo (&key a (b 27)) \"Return :A+:B.\")")
(checkdoc-defun)))
(ert-deftest checkdoc-cl-defun-with-allow-other-keys-ok ()
"Checkdoc should be happy with a cl-defun using &allow-other-keys."
(with-temp-buffer
(emacs-lisp-mode)
(insert "(cl-defun foo (&key a &allow-other-keys) \"Return :A.\")")
(checkdoc-defun)))
(ert-deftest checkdoc-cl-defun-with-default-optional-value-ok ()
"Checkdoc should be happy with a cl-defun using default values for optional args."
(with-temp-buffer
(emacs-lisp-mode)
;; B is optional and equals 1+a if not provided. HAS-BS is non-nil
;; if B was provided in the call:
(insert "(cl-defun foo (a &optional (b (1+ a) has-bs)) \"Return A + B.\")")
(checkdoc-defun)))
(ert-deftest checkdoc-cl-defun-with-destructuring-ok ()
"Checkdoc should be happy with a cl-defun destructuring its arguments."
(with-temp-buffer
(emacs-lisp-mode)
(insert "(cl-defun foo ((a b &optional c) d) \"Return A+B+C+D.\")")
(checkdoc-defun)))
(ert-deftest checkdoc-tests--next-docstring ()
"Checks that the one-argument form of `defvar' works.
See the comments in Bug#24998."