Remove hacks for broken `with-suppressed-warnings'

* test/lisp/obsolete/cl-tests.el (labels-function-quoting):
* test/lisp/tar-mode-tests.el (tar-mode-test-tar-grind-file-mode):
Remove hack for broken `with-suppressed-warnings'.
This commit is contained in:
Stefan Kangas 2021-12-05 12:08:27 +01:00
parent bf869aa698
commit 9167fbd323
2 changed files with 6 additions and 17 deletions

View file

@ -25,17 +25,11 @@
(require 'cl))
(require 'ert)
;; Hack to work around the ERT limitation that we can't reliably use
;; `with-suppressed-warnings' inside an `ert-deftest'. (Bug#36568)
(defun cl-tests-labels-test ()
(with-suppressed-warnings ((obsolete labels))
(funcall (labels ((foo () t))
#'foo))))
(ert-deftest labels-function-quoting ()
"Test that #'foo does the right thing in `labels'." ; Bug#31792.
(should (eq (cl-tests-labels-test) t)))
(with-suppressed-warnings ((obsolete labels))
(should (eq (funcall (labels ((foo () t))
#'foo))
t))))
;;; cl-tests.el ends here

View file

@ -24,12 +24,6 @@
(defvar tar-mode-tests-data-directory
(expand-file-name "test/data/decompress" source-directory))
;; Hack to work around the ERT limitation that we can't reliably use
;; `with-suppressed-warnings' inside an `ert-deftest'. (Bug#36568)
(defun tar-mode-tests--tar-grind-file-mode (&rest args)
(with-suppressed-warnings ((obsolete tar-grind-file-mode))
(apply #'tar-grind-file-mode args)))
(ert-deftest tar-mode-test-tar-grind-file-mode ()
(let ((alist (list (cons 448 "rwx------")
(cons 420 "rw-r--r--")
@ -38,7 +32,8 @@
(cons 1024 "-----S---")
(cons 2048 "--S------"))))
(dolist (x alist)
(should (equal (cdr x) (tar-mode-tests--tar-grind-file-mode (car x)))))))
(with-suppressed-warnings ((obsolete tar-grind-file-mode))
(should (equal (cdr x) (tar-grind-file-mode (car x))))))))
(ert-deftest tar-mode-test-tar-extract-gz ()
(skip-unless (executable-find "gzip"))