procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove hack from seq-tests.el for broken `with-suppressed-warnings'

Browse source 
* test/lisp/emacs-lisp/seq-tests.el: `with-suppressed-warnings'
now works better in erf-deftests, so remove hack that works around
it (bug#36568).
This commit is contained in:
Lars Ingebrigtsen 2021-12-05 04:20:55 +01:00
parent 7842a606b7
commit 8bdea76720
1 changed files with 10 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
test/lisp/emacs-lisp/seq-tests.el
View file

@ -172,23 +172,19 @@ Evaluate BODY for each created sequence.
(should-not (seq-find #'null '(1 2 3)))
(should (seq-find #'null '(1 2 3) 'sentinel)))
;; Hack to work around the ERT limitation that we can't reliably use
;; `with-suppressed-warnings' inside an `ert-deftest'. (Bug#36568)
(defun seq--contains (&rest args)
(with-suppressed-warnings ((obsolete seq-contains))
(apply #'seq-contains args)))
(ert-deftest test-seq-contains ()
(with-test-sequences (seq '(3 4 5 6))
(should (seq--contains seq 3))
(should-not (seq--contains seq 7)))
(with-test-sequences (seq '())
(should-not (seq--contains seq 3))
(should-not (seq--contains seq nil))))
(with-suppressed-warnings ((obsolete seq-contains))
(with-test-sequences (seq '(3 4 5 6))
(should (seq-contains seq 3))
(should-not (seq-contains seq 7)))
(with-test-sequences (seq '())
(should-not (seq-contains seq 3))
(should-not (seq-contains seq nil)))))
(ert-deftest test-seq-contains-should-return-the-elt ()
(with-test-sequences (seq '(3 4 5 6))
(should (= 5 (seq--contains seq 5)))))
(with-suppressed-warnings ((obsolete seq-contains))
(with-test-sequences (seq '(3 4 5 6))
(should (= 5 (seq-contains seq 5))))))
(ert-deftest test-seq-contains-p ()
(with-test-sequences (seq '(3 4 5 6))