From 840c6824589c9a82deedc5112891d8014d134746 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Thu, 27 Feb 2025 15:34:24 +0100 Subject: [PATCH] ; (completion-preview-complete): Fix bug#76606 * lisp/completion-preview.el (completion-preview-complete): Dismiss completion preview before calling ':exit-function'. This eliminates potential flicker with slow exit functions and avoids the broken preview update reported in bug#76606. --- lisp/completion-preview.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el index 4928d9a8824..505cf45f48d 100644 --- a/lisp/completion-preview.el +++ b/lisp/completion-preview.el @@ -520,6 +520,10 @@ completions list." ;; hook update the completion preview in case the candidate ;; can be completed further. (when (functionp efn) + ;; Remove stale preview since `efn' can make arbitrary + ;; text and point modifications that might interfere with + ;; a subsequent preview update. See bug#76606. + (completion-preview-active-mode -1) (funcall efn (concat base com) (if (cdr all) 'exact 'finished))) ;; Otherwise, remove the common prefix from the preview. (completion-preview--inhibit-update)