procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Re-add a useful assertion

Browse source 
* src/emacs-module.c (module_free_global_ref): Re-add assertion that
the reference count is zero.  This assertion was removed in commit
8afaa1321f, but it's not included in the
test performed by XFASTINT before, because the previous reference
count could have been zero already in the case of a buggy
implementation.  This assertion might have detected Bug#27587.
This commit is contained in:
Philipp Stephani 2017-07-10 00:28:50 +02:00
parent 22af69906c
commit 81131ff26f
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/emacs-module.c
View file

@ -328,7 +328,10 @@ module_free_global_ref (emacs_env *env, emacs_value ref)
set_hash_value_slot (h, i, value);
}
else
hash_remove_from_table (h, obj);
{
eassert (refcount == 0);
hash_remove_from_table (h, obj);
}
}
if (module_assertions)