Use lexical-binding in most remaining tests

* test/lisp/comint-tests.el:
* test/lisp/custom-resources/custom--test-theme.el:
* test/lisp/dabbrev-tests.el:
* test/lisp/emulation/viper-tests.el:
* test/lisp/erc/erc-track-tests.el:
* test/lisp/gnus/gnus-tests.el:
* test/lisp/imenu-tests.el:
* test/lisp/info-xref-tests.el:
* test/lisp/jit-lock-tests.el:
* test/lisp/json-tests.el:
* test/lisp/man-tests.el:
* test/lisp/replace-tests.el:
* test/lisp/shadowfile-tests.el:
* test/lisp/subr-tests.el:
* test/lisp/thingatpt-tests.el:
* test/lisp/xml-tests.el: Use lexical-binding.

* test/lisp/man-tests.el (man-tests-filter-strings):
* test/lisp/shadowfile-tests.el (shadow-test00-clusters)
(shadow-test01-sites, shadow-test06-literal-groups)
(shadow-test07-regexp-groups, shadow-test09-shadow-copy-files):
Silence byte-compiler.
This commit is contained in:
Stefan Kangas 2020-05-01 13:02:38 +02:00
parent 0c899eede3
commit 7fa3e754cb
16 changed files with 27 additions and 25 deletions

View file

@ -1,4 +1,4 @@
;;; comint-testsuite.el
;;; comint-tests.el -*- lexical-binding:t -*-
;; Copyright (C) 2010-2020 Free Software Foundation, Inc.

View file

@ -1,3 +1,5 @@
;;; custom--test-theme.el -- A test theme. -*- lexical-binding:t -*-
(deftheme custom--test
"A test theme.")

View file

@ -1,4 +1,4 @@
;;; dabbrev-tests.el --- Test suite for dabbrev.
;;; dabbrev-tests.el --- Test suite for dabbrev. -*- lexical-binding:t -*-
;; Copyright (C) 2016-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; viper-tests.el --- tests for viper.
;;; viper-tests.el --- tests for viper. -*- lexical-binding:t -*-
;; Copyright (C) 2016-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; erc-track-tests.el --- Tests for erc-track.
;;; erc-track-tests.el --- Tests for erc-track. -*- lexical-binding:t -*-
;; Copyright (C) 2016-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; gnus-tests.el --- Wrapper for the Gnus tests
;;; gnus-tests.el --- Wrapper for the Gnus tests -*- lexical-binding:t -*-
;; Copyright (C) 2011-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; imenu-tests.el --- Test suite for imenu.
;;; imenu-tests.el --- Test suite for imenu. -*- lexical-binding:t -*-
;; Copyright (C) 2013-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; info-xref.el --- tests for info-xref.el
;;; info-xref.el --- tests for info-xref.el -*- lexical-binding:t -*-
;; Copyright (C) 2013-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; jit-lock-tests.el --- tests for jit-lock
;;; jit-lock-tests.el --- tests for jit-lock -*- lexical-binding:t -*-
;; Copyright (C) 2016-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; json-tests.el --- Test suite for json.el
;;; json-tests.el --- Test suite for json.el -*- lexical-binding:t -*-
;; Copyright (C) 2015-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; man-tests.el --- Test suite for man.
;;; man-tests.el --- Test suite for man. -*- lexical-binding:t -*-
;; Copyright (C) 2013-2020 Free Software Foundation, Inc.
@ -114,7 +114,7 @@ in the cdr of the element.")
(dolist (test man-tests-parse-man-k-tests)
(should (man-tests-parse-man-k-test-case test))))
(defun man-tests-filter-strings (buffer strings)
(defun man-tests-filter-strings (_buffer strings)
"Run `Man-bgproc-filter' on each of STRINGS.
The formatted result will be inserted into BUFFER."
(let ((proc (start-process "dummy man-tests proc" (current-buffer) "cat")))

View file

@ -1,4 +1,4 @@
;;; replace-tests.el --- tests for replace.el.
;;; replace-tests.el --- tests for replace.el. -*- lexical-binding:t -*-
;; Copyright (C) 2010-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; shadowfile-tests.el --- Tests of shadowfile
;;; shadowfile-tests.el --- Tests of shadowfile -*- lexical-binding:t -*-
;; Copyright (C) 2018-2020 Free Software Foundation, Inc.
@ -138,9 +138,9 @@ guaranteed by the originator of a cluster definition."
;; We must mock `read-from-minibuffer' and `read-string', in
;; order to avoid interactive arguments.
(cl-letf* (((symbol-function #'read-from-minibuffer)
(lambda (&rest args) (pop mocked-input)))
(lambda (&rest _args) (pop mocked-input)))
((symbol-function #'read-string)
(lambda (&rest args) (pop mocked-input))))
(lambda (&rest _args) (pop mocked-input))))
;; Cleanup & initialize.
(shadow--tests-cleanup)
@ -255,9 +255,9 @@ guaranteed by the originator of a cluster definition."
;; We must mock `read-from-minibuffer' and `read-string', in
;; order to avoid interactive arguments.
(cl-letf* (((symbol-function #'read-from-minibuffer)
(lambda (&rest args) (pop mocked-input)))
(lambda (&rest _args) (pop mocked-input)))
((symbol-function #'read-string)
(lambda (&rest args) (pop mocked-input))))
(lambda (&rest _args) (pop mocked-input))))
;; Cleanup & initialize.
(shadow--tests-cleanup)
@ -608,9 +608,9 @@ guaranteed by the originator of a cluster definition."
;; We must mock `read-from-minibuffer' and `read-string', in
;; order to avoid interactive arguments.
(cl-letf* (((symbol-function #'read-from-minibuffer)
(lambda (&rest args) (pop mocked-input)))
(lambda (&rest _args) (pop mocked-input)))
((symbol-function #'read-string)
(lambda (&rest args) (pop mocked-input))))
(lambda (&rest _args) (pop mocked-input))))
;; Cleanup & initialize.
(shadow--tests-cleanup)
@ -669,9 +669,9 @@ guaranteed by the originator of a cluster definition."
;; We must mock `read-from-minibuffer' and `read-string', in
;; order to avoid interactive arguments.
(cl-letf* (((symbol-function #'read-from-minibuffer)
(lambda (&rest args) (pop mocked-input)))
(lambda (&rest _args) (pop mocked-input)))
((symbol-function #'read-string)
(lambda (&rest args) (pop mocked-input))))
(lambda (&rest _args) (pop mocked-input))))
;; Cleanup & initialize.
(shadow--tests-cleanup)
@ -923,7 +923,7 @@ guaranteed by the originator of a cluster definition."
;; action.
(add-function
:before (symbol-function #'write-region)
(lambda (&rest args)
(lambda (&rest _args)
(when (and (buffer-file-name) mocked-input)
(should (equal (buffer-file-name) (pop mocked-input)))))
'((name . "write-region-mock")))

View file

@ -1,4 +1,4 @@
;;; subr-tests.el --- Tests for subr.el
;;; subr-tests.el --- Tests for subr.el -*- lexical-binding:t -*-
;; Copyright (C) 2015-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; thingatpt.el --- tests for thing-at-point.
;;; thingatpt.el --- tests for thing-at-point. -*- lexical-binding:t -*-
;; Copyright (C) 2013-2020 Free Software Foundation, Inc.

View file

@ -1,4 +1,4 @@
;;; xml-parse-tests.el --- Test suite for XML parsing.
;;; xml-parse-tests.el --- Test suite for XML parsing. -*- lexical-binding:t -*-
;; Copyright (C) 2012-2020 Free Software Foundation, Inc.