procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid race condition in parallel native-compilation

Browse source 
* lisp/emacs-lisp/comp.el (comp-delete-or-replace-file): Avoid
race condition by relying on 'rename-file' being an atomic
operation on Posix filesystems.  (Bug#68083)
This commit is contained in:
Aaron Jensen 2023-12-30 18:06:45 -05:00 • committed by Eli Zaretskii
parent 69c98b0e70
commit 6e2e34a5ca
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lisp/emacs-lisp/comp.el
View file

@ -3339,9 +3339,9 @@ session."
;; Remove the old eln instead of copying the new one into it
;; to get a new inode and prevent crashes in case the old one
;; is currently loaded.
(t (delete-file oldfile)
(when newfile
(rename-file newfile oldfile)))))
(t (if newfile
(rename-file newfile oldfile t)
(delete-file oldfile)))))
(defun comp--native-compile (function-or-file &optional with-late-load output)
"Compile FUNCTION-OR-FILE into native code.