procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

(thumbs-find-image): Don't make variables automatically buffer local.

Browse source 
(thumbs-current-tmp-filename, thumbs-current-image-filename, thumbs-image-num):
Make automatically buffer local.
(thumbs-show-thumbs-list): Use `make-local-variable', not
`make-variable-buffer-local'.
(thumbs-insert-image): Make `thumbs-current-image-size' buffer-local.
This commit is contained in:
Juanma Barranquero 2005-08-02 10:26:31 +00:00
parent 2bd5227ede
commit 6ced5724bc
2 changed files with 29 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lisp/ChangeLog
View file

@ -1,5 +1,14 @@
2005-08-02 Juanma Barranquero <lekktu@gmail.com>
* thumbs.el (thumbs-find-image): Don't make variables
automatically buffer local.
(thumbs-current-tmp-filename, thumbs-current-image-filename)
(thumbs-image-num): Make automatically buffer local.
(thumbs-show-thumbs-list): Use `make-local-variable', not
`make-variable-buffer-local'.
(thumbs-insert-image): Make `thumbs-current-image-size'
buffer-local.
* play/doctor.el (doctor-type-symbol): "?\ " -> "?\s".
(**mad**, *debug*, *print-space*, *print-upcase*, abuselst)
(abusewords, account, afraidof, arerelated, areyou, bak, beclst)
@ -16,6 +25,9 @@
(whatwhen, whereoutp, whysay, whywant, zippy-flag, zippylst):
Defvar at compile time.
* progmodes/ada-mode.el (ada-mode): Use `make-local-variable',
not `make-variable-buffer-local'.
2005-08-02 Kim F. Storm <storm@cua.dk>
* emulation/cua-rect.el (cua--highlight-rectangle): Only show

37
lisp/thumbs.el
View file

@ -138,23 +138,25 @@ this value can let another user see some of your images."
:group 'thumbs)
;; Initialize some variable, for later use.
(defvar thumbs-current-tmp-filename
nil
(defvar thumbs-current-tmp-filename nil
"Temporary filename of current image.")
(defvar thumbs-current-image-filename
nil
(make-variable-buffer-local 'thumbs-current-tmp-filename)
(defvar thumbs-current-image-filename nil
"Filename of current image.")
(defvar thumbs-current-image-size
nil
(make-variable-buffer-local 'thumbs-current-image-filename)
(defvar thumbs-current-image-size nil
"Size of current image.")
(defvar thumbs-image-num
nil
(defvar thumbs-image-num nil
"Number of current image.")
(defvar thumbs-current-dir
nil
(make-variable-buffer-local 'thumbs-image-num)
(defvar thumbs-current-dir nil
"Current directory.")
(defvar thumbs-markedL
nil
(defvar thumbs-markedL nil
"List of marked files.")
(defalias 'thumbs-gensym
@ -365,8 +367,8 @@ If MARKED is non-nil, the image is marked."
:conversion ,(if marked 'disabled)
:margin ,thumbs-margin)))
(insert-image i)
(setq thumbs-current-image-size
(image-size i t))))
(set (make-local-variable 'thumbs-current-image-size)
(image-size i t))))
(defun thumbs-insert-thumb (img &optional marked)
"Insert the thumbnail for IMG at point.
@ -397,8 +399,7 @@ If MARKED is non-nil, the image is marked."
(thumbs-mode)
(thumbs-do-thumbs-insertion L)
(goto-char (point-min))
(setq thumbs-current-dir default-directory)
(make-variable-buffer-local 'thumbs-current-dir)))
(set (make-local-variable 'thumbs-current-dir) default-directory)))
;;;###autoload
(defun thumbs-show-all-from-dir (dir &optional reg same-window)
@ -436,10 +437,6 @@ and SAME-WINDOW to show thumbs in the same window."
(setq thumbs-current-image-filename img
thumbs-current-tmp-filename nil
thumbs-image-num (or num 0))
(make-variable-buffer-local 'thumbs-current-image-filename)
(make-variable-buffer-local 'thumbs-current-tmp-filename)
(make-variable-buffer-local 'thumbs-current-image-size)
(make-variable-buffer-local 'thumbs-image-num)
(delete-region (point-min)(point-max))
(thumbs-insert-image img (thumbs-image-type img) 0)))