procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix a mis-binding and a bad defun name in a test (Bug#28319)

Browse source 
test/lib-src/emacs-client-tests.el (call-emacsclient): Rename
emacsclient-test-call-emacsclient.
(emacsclient-test-alternate-editor-allows-arguments)
(emacsclient-test-alternate-editor-allows-quotes): Fix let-binding of
process-environment.

Thanks to Glenn Morris for noticing these errors.
This commit is contained in:
Reuben Thomas 2017-09-01 23:38:31 +01:00
parent cae005f28d
commit 6c995e4194
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
test/lib-src/emacsclient-tests.el
View file

@ -31,26 +31,26 @@
"lib-src"))
"Path to emacsclient binary in build tree.")
(defun call-emacsclient ()
(defun emacsclient-test-call-emacsclient ()
"Run emacsclient."
(call-process emacsclient-test-emacs nil nil nil
"--server-file" (expand-file-name "non-existent-file" invocation-directory)
"foo"))
(ert-deftest emacsclient-test-alternate-editor-allows-arguments ()
(let (process-environment process-environment)
(let ((process-environment process-environment))
(setenv "ALTERNATE_EDITOR" (concat
(expand-file-name invocation-name invocation-directory)
" --batch"))
(should (= 0 (call-emacsclient)))))
(should (= 0 (emacsclient-test-call-emacsclient)))))
(ert-deftest emacsclient-test-alternate-editor-allows-quotes ()
(let (process-environment process-environment)
(let ((process-environment process-environment))
(setenv "ALTERNATE_EDITOR" (concat
"\""
(expand-file-name invocation-name invocation-directory)
"\"" " --batch"))
(should (= 0 (call-emacsclient)))))
(should (= 0 (emacsclient-test-call-emacsclient)))))
(provide 'emacsclient-tests)
;;; emacsclient-tests.el ends here