eshell-eval-using-options: Avoid compiler warning differently

* lisp/eshell/em-unix.el (eshell/time):
* lisp/eshell/em-tramp.el (eshell/sudo):
* lisp/eshell/esh-var.el (eshell/env): Remove artificial use of `args'.

* lisp/eshell/esh-opt.el (eshell-eval-using-options): Silence warning
when `args' is not used by `body-forms'.
This commit is contained in:
Stefan Monnier 2018-03-10 21:49:22 -05:00
parent a3f26048a9
commit 6a2d179a47
4 changed files with 4 additions and 6 deletions

View file

@ -109,7 +109,6 @@ Uses the system sudo through TRAMP's sudo method."
:show-usage
:usage "[(-u | --user) USER] COMMAND
Execute a COMMAND as the superuser or another USER.")
args ; suppress "unused lexical variable" warning
(throw 'eshell-external
(let ((user (or user "root"))
(host (or (file-remote-p default-directory 'host)

View file

@ -956,7 +956,6 @@ Summarize disk usage of each FILE, recursively for directories.")
:show-usage
:usage "COMMAND...
Show wall-clock time elapsed during execution of COMMAND.")
args ; suppress "unused lexical variable" warning
(setq eshell-time-start (float-time))
(add-hook 'eshell-post-command-hook 'eshell-show-elapsed-time nil t)
;; after setting

View file

@ -95,8 +95,8 @@ BODY-FORMS. If instead an external command is run (because of
an unknown option), the tag `eshell-external' will be thrown with
the new process for its value.
Lastly, any remaining arguments will be available in a locally
interned variable `args' (created using a `let' form)."
Lastly, any remaining arguments will be available in the locally
let-bound variable `args'."
(declare (debug (form form sexp body)))
`(let* ((temp-args
,(if (memq ':preserve-args (cadr options))
@ -111,7 +111,8 @@ interned variable `args' (created using a `let' form)."
;; `options' is of the form (quote OPTS).
(cadr options))))
(args processed-args))
;; Unused lexical variable warning if body does not use `args'.
;; Silence unused lexical variable warning if body does not use `args'.
(ignore args)
,@body-forms))
;;; Internal Functions:

View file

@ -353,7 +353,6 @@ This function is explicit for adding to `eshell-parse-argument-hook'."
'((?h "help" nil nil "show this usage screen")
:external "env"
:usage "<no arguments>")
args ; suppress "unused lexical variable" warning
(dolist (setting (sort (eshell-environment-variables) 'string-lessp))
(eshell-buffered-print setting "\n"))
(eshell-flush)))