Allow read-passwd to hide characters inserted by C-y. (Security fix.)

This fixes bug #30186.  The with-silent-modifications was there to prevent
records of text property manipulations being put into buffer-undo-list.  These
had been causing a significant slowdown in CC Mode with C-_ after a large
C-y.  This CC Mode problem has since been solved by a different workaround.

* lisp/subr.el (remove-yank-excluded-properties): Remove the invocation of
with-silent-modifications around the text property manipulations.
This commit is contained in:
Alan Mackenzie 2018-01-27 22:02:45 +00:00
parent 8cb4ffb262
commit 6415b2d40c

View file

@ -3019,10 +3019,9 @@ remove properties specified by `yank-excluded-properties'."
run-start prop nil end)))
(funcall fun value run-start run-end)
(setq run-start run-end)))))
(with-silent-modifications
(if (eq yank-excluded-properties t)
(set-text-properties start end nil)
(remove-list-of-text-properties start end yank-excluded-properties)))))
(if (eq yank-excluded-properties t)
(set-text-properties start end nil)
(remove-list-of-text-properties start end yank-excluded-properties))))
(defvar yank-undo-function)