procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

* lisp/progmodes/python.el (python-shell-prompt-detect): Remove redundant

Browse source 
executable-find.

Fixes: debbugs:18244
This commit is contained in:
Stefan Monnier 2014-08-18 12:11:43 -04:00
parent 73b7592be7
commit 5d3c0a067f
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lisp/ChangeLog
View file

@ -1,5 +1,8 @@
2014-08-18 Stefan Monnier <monnier@iro.umontreal.ca>
* progmodes/python.el (python-shell-prompt-detect): Remove redundant
executable-find (bug#18244).
* simple.el (self-insert-uses-region-functions): Defvar.
2014-08-13 Leo Liu <sdl.web@gmail.com>

12
lisp/progmodes/python.el
View file

@ -1894,7 +1894,7 @@ detection and just returns nil."
(let ((code-file (python-shell--save-temp-file code)))
;; Use `process-file' as it is remote-host friendly.
(process-file
(executable-find python-shell-interpreter)
python-shell-interpreter
code-file
'(t nil)
nil
@ -2048,11 +2048,14 @@ uniqueness for different types of configurations."
(or python-shell-virtualenv-path "")
(mapconcat #'identity python-shell-exec-path "")))))
(defun python-shell-parse-command ()
(defun python-shell-parse-command () ;FIXME: why name it "parse"?
"Calculate the string used to execute the inferior Python process."
;; FIXME: process-environment doesn't seem to be used anywhere within
;; this let.
(let ((process-environment (python-shell-calculate-process-environment))
(exec-path (python-shell-calculate-exec-path)))
(format "%s %s"
;; FIXME: Why executable-find?
(executable-find python-shell-interpreter)
python-shell-interpreter-args)))
@ -2084,11 +2087,10 @@ uniqueness for different types of configurations."
(defun python-shell-calculate-exec-path ()
"Calculate exec path given `python-shell-virtualenv-path'."
(let ((path (append python-shell-exec-path
exec-path nil)))
exec-path nil))) ;FIXME: Why nil?
(if (not python-shell-virtualenv-path)
path
(cons (format "%s/bin"
(directory-file-name python-shell-virtualenv-path))
(cons (expand-file-name "bin" python-shell-virtualenv-path)
path))))
(defun python-comint-output-filter-function (output)