procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use known length of a Lisp string to copy it faster.

Browse source 
* lisp.h (lispstrcpy): New function.  Add comment.
* callproc.c (child_setup):
* dbusbind.c (xd_append_arg):
* doc.c (get_doc_string):
* font.c (Ffont_xlfd_name):
* frame.c (xrdb_get_resource):
* process.c (Fmake_network_process, network_interface_info):
* w32fns.c (Fx_open_connection):
* w32proc.c (sys_spawnve):
* xfns.c (select_visual):
* xfont.c (xfont_list):
* xsmfns.c (x_session_initialize):
* xterm.c (x_term_init): Use it.
This commit is contained in:
Dmitry Antipov 2014-09-23 19:49:00 +04:00
parent c03d2c89fb
commit 59e10fbd93
14 changed files with 41 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/ChangeLog
View file

@ -1,7 +1,24 @@
2014-09-23 Dmitry Antipov <dmantipov@yandex.ru>
Use known length of a Lisp string to copy it faster.
* lisp.h (lispstrcpy): New function. Add comment.
* callproc.c (child_setup):
* dbusbind.c (xd_append_arg):
* doc.c (get_doc_string):
* font.c (Ffont_xlfd_name):
* frame.c (xrdb_get_resource):
* process.c (Fmake_network_process, network_interface_info):
* w32fns.c (Fx_open_connection):
* w32proc.c (sys_spawnve):
* xfns.c (select_visual):
* xfont.c (xfont_list):
* xsmfns.c (x_session_initialize):
* xterm.c (x_term_init): Use it.
2014-09-23 Paul Eggert <eggert@cs.ucla.edu>
Fix SAFE_ALLOCA to not exhaust the stack when in a loop.
Problem reported by Dmietry Antipov in thread leading to:
Problem reported by Dmitry Antipov in thread leading to:
http://lists.gnu.org/archive/html/emacs-devel/2014-09/msg00713.html
This patch fixes only SAFE_ALLOCA, SAFE_NALLOCA, and SAFE_ALLOCA_LISP;
the experimental local_* macros enabled by USE_LOCAL_ALLOCATORS

2
src/callproc.c
View file

@ -1235,7 +1235,7 @@ child_setup (int in, int out, int err, char **new_argv, bool set_pgrp,
#endif
temp = pwd_var + 4;
memcpy (pwd_var, "PWD=", 4);
strcpy (temp, SSDATA (current_dir));
lispstrcpy (temp, current_dir);
#ifndef DOS_NT
/* We can't signal an Elisp error here; we're in a vfork. Since

2
src/dbusbind.c
View file

@ -761,7 +761,7 @@ xd_append_arg (int dtype, Lisp_Object object, DBusMessageIter *iter)
&& STRINGP (CAR_SAFE (XD_NEXT_VALUE (object)))
&& NILP (CDR_SAFE (XD_NEXT_VALUE (object))))
{
strcpy (signature, SSDATA (CAR_SAFE (XD_NEXT_VALUE (object))));
lispstrcpy (signature, CAR_SAFE (XD_NEXT_VALUE (object)));
object = CDR_SAFE (XD_NEXT_VALUE (object));
}

2
src/doc.c
View file

@ -121,7 +121,7 @@ get_doc_string (Lisp_Object filepos, bool unibyte, bool definition)
if (minsize < 8)
minsize = 8;
name = SAFE_ALLOCA (minsize + SCHARS (file) + 8);
strcpy (name, SSDATA (docdir));
lispstrcpy (name, docdir);
strcat (name, SSDATA (file));
}
else

2
src/font.c
View file

@ -4266,7 +4266,7 @@ the consecutive wildcards are folded into one. */)
{
if (NILP (fold_wildcards))
return font_name;
strcpy (name, SSDATA (font_name));
lispstrcpy (name, font_name);
namelen = SBYTES (font_name);
goto done;
}

4
src/frame.c
View file

@ -4036,8 +4036,8 @@ xrdb_get_resource (XrmDatabase rdb, Lisp_Object attribute, Lisp_Object class, Li
/* Start with emacs.FRAMENAME for the name (the specific one)
and with `Emacs' for the class key (the general one). */
strcpy (name_key, SSDATA (Vx_resource_name));
strcpy (class_key, SSDATA (Vx_resource_class));
lispstrcpy (name_key, Vx_resource_name);
lispstrcpy (class_key, Vx_resource_class);
strcat (class_key, ".");
strcat (class_key, SSDATA (class));

9
src/lisp.h
View file

@ -4462,6 +4462,15 @@ extern void *xpalloc (void *, ptrdiff_t *, ptrdiff_t, ptrdiff_t, ptrdiff_t);
extern char *xstrdup (const char *) ATTRIBUTE_MALLOC;
extern char *xlispstrdup (Lisp_Object) ATTRIBUTE_MALLOC;
extern void dupstring (char **, char const *);
/* Like strcpy but uses known length of a Lisp string. */
INLINE char *
lispstrcpy (const char *dest, Lisp_Object string)
{
return memcpy ((void *) dest, SSDATA (string), SBYTES (string) + 1);
}
extern void xputenv (const char *);
extern char *egetenv_internal (const char *, ptrdiff_t);

4
src/process.c
View file

@ -2989,7 +2989,7 @@ usage: (make-network-process &rest ARGS) */)
address_un.sun_family = AF_LOCAL;
if (sizeof address_un.sun_path <= SBYTES (service))
error ("Service name too long");
strcpy (address_un.sun_path, SSDATA (service));
lispstrcpy (address_un.sun_path, service);
ai.ai_addr = (struct sockaddr *) &address_un;
ai.ai_addrlen = sizeof address_un;
goto open_socket;
@ -3680,7 +3680,7 @@ network_interface_info (Lisp_Object ifname)
if (sizeof rq.ifr_name <= SBYTES (ifname))
error ("interface name too long");
strcpy (rq.ifr_name, SSDATA (ifname));
lispstrcpy (rq.ifr_name, ifname);
s = socket (AF_INET, SOCK_STREAM | SOCK_CLOEXEC, 0);
if (s < 0)

2
src/w32fns.c
View file

@ -5339,7 +5339,7 @@ terminate Emacs if we can't open the connection.
{
char basename[ MAX_PATH ], *str;
strcpy (basename, SDATA (Vinvocation_name));
lispstrcpy (basename, Vinvocation_name);
str = strrchr (basename, '.');
if (str) *str = 0;
Vinvocation_name = build_string (basename);

2
src/w32proc.c
View file

@ -1647,7 +1647,7 @@ sys_spawnve (int mode, char *cmdname, char **argv, char **envp)
strcpy (cmdname, egetenv ("CMDPROXY"));
else
{
strcpy (cmdname, SDATA (Vinvocation_directory));
lispstrcpy (cmdname, Vinvocation_directory);
strcat (cmdname, "cmdproxy.exe");
}

2
src/xfns.c
View file

@ -4289,7 +4289,7 @@ select_visual (struct x_display_info *dpyinfo)
int i, class = -1;
XVisualInfo vinfo;
strcpy (s, SSDATA (value));
lispstrcpy (s, value);
dash = strchr (s, '-');
if (dash)
{

2
src/xfont.c
View file

@ -541,7 +541,7 @@ xfont_list (struct frame *f, Lisp_Object spec)
if (STRINGP (XCAR (alter))
&& ((r - name) + SBYTES (XCAR (alter))) < 256)
{
strcpy (r, SSDATA (XCAR (alter)));
lispstrcpy (r, XCAR (alter));
list = xfont_list_pattern (display, name, registry, script);
if (! NILP (list))
break;

2
src/xsmfns.c
View file

@ -418,7 +418,7 @@ x_session_initialize (struct x_display_info *dpyinfo)
emacs_program[0] = '\0';
if (! EQ (Vinvocation_directory, Qnil))
strcpy (emacs_program, SSDATA (Vinvocation_directory));
lispstrcpy (emacs_program, Vinvocation_directory);
strcat (emacs_program, SSDATA (Vinvocation_name));
/* The SM protocol says all callbacks are mandatory, so set up all

2
src/xterm.c
View file

@ -10902,7 +10902,7 @@ x_term_init (Lisp_Object display_name, char *xrm_option, char *resource_name)
dpyinfo->x_id = ++x_display_id;
dpyinfo->x_id_name = xmalloc (SBYTES (Vinvocation_name)
+ SBYTES (Vsystem_name) + 2);
strcat (strcat (strcpy (dpyinfo->x_id_name, SSDATA (Vinvocation_name)), "@"),
strcat (strcat (lispstrcpy (dpyinfo->x_id_name, Vinvocation_name), "@"),
SSDATA (Vsystem_name));
/* Figure out which modifier bits mean what. */