procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Mark whole-script confusables as suspicious domains

Browse source 
* lisp/international/textsec.el (textsec-domain-suspicious-p):
Consider domain names that are whole-script confusables with ASCII
to be suspicious.  (I think this is what the Unicode standard is
recommending, but I'm not 100% sure.)
This commit is contained in:
Lars Ingebrigtsen 2022-01-19 15:52:20 +01:00
parent 124c4ad1e5
commit 598038643f
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lisp/international/textsec.el
View file

@ -245,8 +245,14 @@ or use certain other unusual mixtures of characters."
(throw 'found (format "Disallowed character: `%s' (#x%x)"
(string char) char))))
domain)
;; Does IDNA allow it?
(unless (puny-highly-restrictive-domain-p domain)
(throw 'found (format "%s is not highly-restrictive" domain)))
(throw 'found (format "`%s' is not highly-restrictive" domain)))
;; Check whether any segment of the domain name is confusable with
;; an ASCII-only segment.
(dolist (elem (split-string domain "\\."))
(when (textsec-ascii-confusable-p elem)
(throw 'found (format "`%s' is confusable with ASCII" elem))))
nil))
(defun textsec-local-address-suspicious-p (local)

5
test/lisp/international/textsec-tests.el
View file

@ -113,7 +113,10 @@
(ert-deftest test-suspiction-domain ()
(should (textsec-domain-suspicious-p "foo/bar.org"))
(should-not (textsec-domain-suspicious-p "foo.org"))
(should (textsec-domain-suspicious-p "f\N{LEFT-TO-RIGHT ISOLATE}oo.org")))
(should (textsec-domain-suspicious-p "f\N{LEFT-TO-RIGHT ISOLATE}oo.org"))
(should (textsec-domain-suspicious-p "Сгсе.ru"))
(should-not (textsec-domain-suspicious-p "фСгсе.ru")))
(ert-deftest test-suspicious-local ()
(should-not (textsec-local-address-suspicious-p "larsi"))