procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

erc: Don't announce broken functionality in /query docstring

Browse source 
* lisp/erc/erc.el (erc-cmd-QUERY): Be less enthusiastic about
announcing missing/broken functionality.  The comment "except this is
broken right now" has been there since 2008, and it's not obvious to
me that we should ever re-add it.
This commit is contained in:
Stefan Kangas 2021-11-11 18:39:19 +01:00
parent e30cb92db6
commit 585e2103df
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lisp/erc/erc.el
View file

@ -3606,11 +3606,13 @@ other people should be displayed."
(defun erc-cmd-QUERY (&optional user)
"Open a query with USER.
The type of query window/frame/etc will depend on the value of
`erc-query-display'.
If USER is omitted, close the current query buffer if one exists
- except this is broken now ;-)"
How the query is displayed (in a new window, frame, etc.) depends
on the value of `erc-query-display'."
;; FIXME: The doc string used to say at the end:
;; "If USER is omitted, close the current query buffer if one exists
;; - except this is broken now ;-)"
;; Does it make sense to have that functionality? What's wrong with
;; `kill-buffer'? If it makes sense, re-add it. -- SK @ 2021-11-11
(interactive
(list (read-string "Start a query with: ")))
(let ((session-buffer (erc-server-buffer))