procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don’t assume CURRENT_TIME_LIST

Browse source 
* lisp/gnus/gnus-delay.el (gnus-delay-send-queue):
* lisp/gnus/nnmail.el (nnmail-activate):
* lisp/mh-e/mh-alias.el (mh-alias-tstamp):
* lisp/net/newst-backend.el (newsticker--cache-item-compare-by-time):
Use time-less-p instead of assuming timestamp format.
This commit is contained in:
Paul Eggert 2019-02-09 19:22:53 -08:00
parent 1e155dcc8d
commit 57646401f1
4 changed files with 6 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lisp/gnus/gnus-delay.el
View file

@ -166,9 +166,7 @@ DELAY is a string, giving the length of the time. Possible values are:
(setq deadline (nnheader-header-value))
(setq deadline (apply 'encode-time
(parse-time-string deadline)))
(setq deadline (time-since deadline))
(when (and (>= (nth 0 deadline) 0)
(>= (nth 1 deadline) 0))
(unless (time-less-p nil deadline)
(message "Sending delayed article %d" article)
(gnus-draft-send article group)
(message "Sending delayed article %d...done" article)))

7
lisp/gnus/nnmail.el
View file

@ -1543,11 +1543,8 @@ See the documentation for the variable `nnmail-split-fancy' for details."
(format "%s-active-timestamp"
backend)))
(error 'none))))
(not (consp timestamp))
(equal timestamp '(0 0))
(> (nth 0 file-time) (nth 0 timestamp))
(and (= (nth 0 file-time) (nth 0 timestamp))
(> (nth 1 file-time) (nth 1 timestamp))))))
(eq timestamp 'none)
(time-less-p timestamp file-time))))
(save-excursion
(or (eq timestamp 'none)
(set (intern (format "%s-active-timestamp" backend))

4
lisp/mh-e/mh-alias.el
View file

@ -80,9 +80,7 @@ If ARG is non-nil, set timestamp with the current time."
(when (and file (file-exists-p file))
(setq stamp (file-attribute-modification-time
(file-attributes file)))
(or (> (car stamp) (car mh-alias-tstamp))
(and (= (car stamp) (car mh-alias-tstamp))
(> (cadr stamp) (cadr mh-alias-tstamp)))))))
(time-less-p mh-alias-tstamp stamp))))
(mh-alias-filenames t)))))))
(defun mh-alias-filenames (arg)

18
lisp/net/newst-backend.el
View file

@ -2171,22 +2171,8 @@ well."
(throw 'result nil))
((eq age2 'obsolete)
(throw 'result t)))))
(let* ((time1 (newsticker--time item1))
(time2 (newsticker--time item2)))
(cond ((< (nth 0 time1) (nth 0 time2))
nil)
((> (nth 0 time1) (nth 0 time2))
t)
((< (nth 1 time1) (nth 1 time2))
nil)
((> (nth 1 time1) (nth 1 time2))
t)
((< (or (nth 2 time1) 0) (or (nth 2 time2) 0))
nil)
((> (or (nth 2 time1) 0) (or (nth 2 time2) 0))
t)
(t
nil)))))
(time-less-p (newsticker--time item2)
(newsticker--time item1))))
(defun newsticker--cache-item-compare-by-title (item1 item2)
"Compare ITEM1 and ITEM2 by comparing their titles."