procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix rcirc not to interpret nil as nickname (bug#37344)

Browse source 
* lisp/net/rcirc.el (rcirc-send-privmsg): Type check `target'.
(rcirc-cmd-me): Send CTCP only when `target' exists.
This commit is contained in:
Leo Liu 2019-10-07 18:52:33 +08:00
parent bd0f173199
commit 55dcd32ad2
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lisp/net/rcirc.el
View file

@ -825,6 +825,7 @@ Function is called with PROCESS, COMMAND, SENDER, ARGS and LINE.")
(process-send-string process string))) (process-send-string process string)))
(defun rcirc-send-privmsg (process target string) (defun rcirc-send-privmsg (process target string)
(cl-check-type target string)
(rcirc-send-string process (format "PRIVMSG %s :%s" target string))) (rcirc-send-string process (format "PRIVMSG %s :%s" target string)))
(defun rcirc-send-ctcp (process target request &optional args) (defun rcirc-send-ctcp (process target request &optional args)
@ -2337,8 +2338,8 @@ With a prefix arg, prompt for new topic."
(let ((timestamp (format-time-string "%s"))) (let ((timestamp (format-time-string "%s")))
(rcirc-send-ctcp process target "PING" timestamp))) (rcirc-send-ctcp process target "PING" timestamp)))
(defun rcirc-cmd-me (args &optional process target) (defun rcirc-cmd-me (args process target)
(rcirc-send-ctcp process target "ACTION" args)) (when target (rcirc-send-ctcp process target "ACTION" args)))
(defun rcirc-add-or-remove (set &rest elements) (defun rcirc-add-or-remove (set &rest elements)
(dolist (elt elements) (dolist (elt elements)