procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Additional type checking in secrets API

Browse source
This commit is contained in:
Daniel Colascione 2014-02-21 16:47:42 -08:00
parent 363362c5cb
commit 4e6526341d
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lisp/ChangeLog
View file

@ -1,3 +1,9 @@
2014-02-22 Daniel Colascione <dancol@dancol.org>
* net/secrets.el (secrets-create-item,secrets-search-items): Check
that attribute values are strings, avoiding the construction of
invalid dbus messages.
2014-02-21 Juanma Barranquero <lekktu@gmail.com>
* emacs-lisp/gv.el: Avoid duplicating gv-expander and gv-setter in

4
lisp/net/secrets.el
View file

@ -609,6 +609,8 @@ The object paths of the found items are returned as list."
(while (consp (cdr attributes))
(unless (keywordp (car attributes))
(error 'wrong-type-argument (car attributes)))
(unless (stringp (cadr attributes))
(error 'wrong-type-argument (cadr attributes)))
(setq props (add-to-list
'props
(list :dict-entry
@ -647,6 +649,8 @@ The object path of the created item is returned."
(while (consp (cdr attributes))
(unless (keywordp (car attributes))
(error 'wrong-type-argument (car attributes)))
(unless (stringp (cadr attributes))
(error 'wrong-type-argument (cadr attributes)))
(setq props (add-to-list
'props
(list :dict-entry