procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

; Use ert-skip instead of skip-when in erc-match test

Browse source 
* test/lisp/erc/erc-match-tests.el (erc-add-entry-to-list): The local
macro `skip-when' first appeared in Emacs 30, but ERC supports Emacs 27+
and runs its test suite on all supported versions.
* test/lisp/erc/erc-scenarios-keep-place-indicator.el
(erc-scenarios-keep-place-indicator--follow): Temporarily tag as
:unstable in all CI environments.
This commit is contained in:
F. Jason Park 2025-03-01 06:26:33 -08:00
parent 3a8ce5ac9c
commit 4be2574851
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
test/lisp/erc/erc-match-tests.el
View file

@ -29,7 +29,9 @@
(ert-deftest erc-add-entry-to-list ()
;; These tests currently freeze in Android.
(skip-when (featurep 'android))
(when (featurep 'android)
(ert-skip "Freezes on Android as of 31.0.50"))
(let ((erc-pals '("z"))
(erc-match-quote-when-adding 'ask))

2
test/lisp/erc/erc-scenarios-keep-place-indicator.el
View file

@ -31,7 +31,7 @@
;; away, the indicator is updated if it's earlier in the buffer.
(ert-deftest erc-scenarios-keep-place-indicator--follow ()
:tags `(:expensive-test
,@(and (getenv "EMACS_EMBA_CI") '(:unstable))
,@(and (getenv "CI") '(:unstable))
,@(and (getenv "ERC_TESTS_GRAPHICAL") '(:erc--graphical)))
(when (version< emacs-version "29") (ert-skip "Times out"))
;; XXX verify that this continues to be the case ^.