Fix a few Edebug specifications where code is wrapped in lambdas.
As the Info node `(elisp) Specification List' explains, it is not correct to use `body' or t for a piece of code that the macro wraps in a `lambda' form. These should use `def-body' instead. * lisp/info-xref.el (info-xref-with-file): * lisp/subr.el (subr--with-wrapper-hook-no-warnings, track-mouse) (combine-change-calls, with-eval-after-load): * lisp/emacs-lisp/bytecomp.el (displaying-byte-compile-warnings): * lisp/emacs-lisp/cl-macs.el (cl-do-symbols, cl-progv): * lisp/emacs-lisp/ert-x.el (ert-with-test-buffer): * lisp/emacs-lisp/gv.el (gv-letplace): * lisp/emacs-lisp/nadvice.el (define-advice): * lisp/emacs-lisp/thunk.el (thunk-delay): * lisp/vc/vc-dispatcher.el (vc-run-delayed): Use 'def-body' instead of t or 'body' where applicable. * lisp/emacs-lisp/package.el (package--with-response-buffer): Remove evaluation of the body altogether. I have no idea how to write it correctly in this case.
This commit is contained in:
parent
e761e12498
commit
42950e9e46
10 changed files with 18 additions and 14 deletions
|
@ -1758,7 +1758,7 @@ It is too wide if it has any lines longer than the largest of
|
|||
overriding-plist-environment)))))
|
||||
|
||||
(defmacro displaying-byte-compile-warnings (&rest body)
|
||||
(declare (debug t))
|
||||
(declare (debug (def-body)))
|
||||
`(let* ((--displaying-byte-compile-warnings-fn (lambda () ,@body))
|
||||
(warning-series-started
|
||||
(and (markerp warning-series)
|
||||
|
|
|
@ -1924,7 +1924,8 @@ from OBARRAY.
|
|||
|
||||
\(fn (VAR [OBARRAY [RESULT]]) BODY...)"
|
||||
(declare (indent 1)
|
||||
(debug ((symbolp &optional form form) cl-declarations body)))
|
||||
(debug ((symbolp &optional form form) cl-declarations
|
||||
def-body)))
|
||||
;; Apparently this doesn't have an implicit block.
|
||||
`(cl-block nil
|
||||
(let (,(car spec))
|
||||
|
@ -1964,7 +1965,7 @@ Each symbol in the first list is bound to the corresponding value in the
|
|||
second list (or to nil if VALUES is shorter than SYMBOLS); then the
|
||||
BODY forms are executed and their result is returned. This is much like
|
||||
a `let' form, except that the list of symbols can be computed at run-time."
|
||||
(declare (indent 2) (debug (form form body)))
|
||||
(declare (indent 2) (debug (form form def-body)))
|
||||
(let ((bodyfun (make-symbol "body"))
|
||||
(binds (make-symbol "binds"))
|
||||
(syms (make-symbol "syms"))
|
||||
|
|
|
@ -98,7 +98,7 @@ To be used in ERT tests. If BODY finishes successfully, the test
|
|||
buffer is killed; if there is an error, the test buffer is kept
|
||||
around on error for further inspection. Its name is derived from
|
||||
the name of the test and the result of NAME-FORM."
|
||||
(declare (debug ((":name" form) body))
|
||||
(declare (debug ((":name" form) def-body))
|
||||
(indent 1))
|
||||
`(ert--call-with-test-buffer ,name-form (lambda () ,@body)))
|
||||
|
||||
|
|
|
@ -135,7 +135,7 @@ The returned value will then be an Elisp expression that first evaluates
|
|||
all the parts of PLACE that can be evaluated and then runs E.
|
||||
|
||||
\(fn (GETTER SETTER) PLACE &rest BODY)"
|
||||
(declare (indent 2) (debug (sexp form body)))
|
||||
(declare (indent 2) (debug (sexp form def-body)))
|
||||
`(gv-get ,place (lambda ,vars ,@body)))
|
||||
|
||||
;; Different ways to declare a generalized variable.
|
||||
|
|
|
@ -503,7 +503,7 @@ arguments. Note if NAME is nil the advice is anonymous;
|
|||
otherwise it is named `SYMBOL@NAME'.
|
||||
|
||||
\(fn SYMBOL (WHERE LAMBDA-LIST &optional NAME DEPTH) &rest BODY)"
|
||||
(declare (indent 2) (doc-string 3) (debug (sexp sexp body)))
|
||||
(declare (indent 2) (doc-string 3) (debug (sexp sexp def-body)))
|
||||
(or (listp args) (signal 'wrong-type-argument (list 'listp args)))
|
||||
(or (<= 2 (length args) 4)
|
||||
(signal 'wrong-number-of-arguments (list 2 4 (length args))))
|
||||
|
|
|
@ -1305,7 +1305,10 @@ is non-nil, don't propagate connection errors (does not apply to
|
|||
errors signaled by ERROR-FORM or by BODY).
|
||||
|
||||
\(fn URL &key ASYNC FILE ERROR-FORM NOERROR &rest BODY)"
|
||||
(declare (indent defun) (debug t))
|
||||
(declare (indent defun)
|
||||
;; FIXME: This should be something like
|
||||
;; `form def-body &rest form', but that doesn't work.
|
||||
(debug (form &rest sexp)))
|
||||
(while (keywordp (car body))
|
||||
(setq body (cdr (cdr body))))
|
||||
`(package--with-response-buffer-1 ,url (lambda () ,@body)
|
||||
|
|
|
@ -52,7 +52,7 @@
|
|||
|
||||
(defmacro thunk-delay (&rest body)
|
||||
"Delay the evaluation of BODY."
|
||||
(declare (debug t))
|
||||
(declare (debug (def-body)))
|
||||
(cl-assert lexical-binding)
|
||||
`(let (forced
|
||||
(val (lambda () ,@body)))
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue