procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove extraneous messages in 2011-03-30 completion change.

Browse source 
These blocked the minibuffer contents when completing in the minibuffer, in a
departure from previous Emacs behavior.

* lisp/minibuffer.el (completion-in-region--postch)
(completion-in-region-mode): Remove unnecessary messages.
This commit is contained in:
Chong Yidong 2011-04-05 17:19:42 -04:00
parent 33256f149f
commit 41ea9e4837
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lisp/ChangeLog
View file

@ -1,3 +1,8 @@
2011-04-05 Chong Yidong <cyd@stupidchicken.com>
* minibuffer.el (completion-in-region--postch)
(completion-in-region-mode): Remove unnecessary messages.
2011-04-05 Juanma Barranquero <lekktu@gmail.com>
* font-lock.el (font-lock-refresh-defaults):

7
lisp/minibuffer.el
View file

@ -1278,7 +1278,6 @@ Point needs to be somewhere between START and END."
;; - pcomplete: pop it down on SPC or after some time-delay.
;; - semantic: use a post-command-hook check similar to this one.
(defun completion-in-region--postch ()
(message "completion-in-region--postch: cmd=%s" this-command)
(or unread-command-events ;Don't pop down the completions in the middle of
;mouse-drag-region/mouse-set-point.
(and completion-in-region--data
@ -1310,10 +1309,8 @@ Point needs to be somewhere between START and END."
(delq (assq 'completion-in-region-mode minor-mode-overriding-map-alist)
minor-mode-overriding-map-alist))
(if (null completion-in-region-mode)
(progn
(unless (equal "*Completions*" (buffer-name (window-buffer)))
(minibuffer-hide-completions))
(message "Leaving completion-in-region-mode"))
(unless (equal "*Completions*" (buffer-name (window-buffer)))
(minibuffer-hide-completions))
;; (add-hook 'pre-command-hook #'completion-in-region--prech)
(add-hook 'post-command-hook #'completion-in-region--postch)
(push `(completion-in-region-mode . ,completion-in-region-mode-map)