procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove an unused parameter from 'child_setup' function.

Browse source 
* src/callproc.c (child_setup): Remove unused SET_PGRP parameter.

* src/callproc.c (call_process):
* src/process.c (create_process): Fix all callers.
This commit is contained in:
Philipp Stephani 2020-12-23 11:43:37 +01:00
parent 268a3d32fb
commit 3edc4fd53f
3 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/callproc.c
View file

@ -542,7 +542,7 @@ call_process (ptrdiff_t nargs, Lisp_Object *args, int filefd,
}
#ifdef MSDOS /* MW, July 1993 */
status = child_setup (filefd, fd_output, fd_error, new_argv, 0, current_dir);
status = child_setup (filefd, fd_output, fd_error, new_argv, current_dir);
if (status < 0)
{
@ -589,7 +589,7 @@ call_process (ptrdiff_t nargs, Lisp_Object *args, int filefd,
block_child_signal (&oldset);
#ifdef WINDOWSNT
pid = child_setup (filefd, fd_output, fd_error, new_argv, 0, current_dir);
pid = child_setup (filefd, fd_output, fd_error, new_argv, current_dir);
#else /* not WINDOWSNT */
/* vfork, and prevent local vars from being clobbered by the vfork. */
@ -646,7 +646,7 @@ call_process (ptrdiff_t nargs, Lisp_Object *args, int filefd,
signal (SIGPROF, SIG_DFL);
#endif
child_setup (filefd, fd_output, fd_error, new_argv, 0, current_dir);
child_setup (filefd, fd_output, fd_error, new_argv, current_dir);
}
#endif /* not WINDOWSNT */
@ -1205,8 +1205,6 @@ exec_failed (char const *name, int err)
Initialize inferior's priority, pgrp, connected dir and environment.
then exec another program based on new_argv.
If SET_PGRP, put the subprocess into a separate process group.
CURRENT_DIR is an elisp string giving the path of the current
directory the subprocess should have. Since we can't really signal
a decent error from within the child, this should be verified as an
@ -1217,7 +1215,7 @@ exec_failed (char const *name, int err)
On MS-DOS, either return an exit status or signal an error. */
CHILD_SETUP_TYPE
child_setup (int in, int out, int err, char **new_argv, bool set_pgrp,
child_setup (int in, int out, int err, char **new_argv,
Lisp_Object current_dir)
{
char **env;

2
src/lisp.h
View file

@ -4500,7 +4500,7 @@ extern void setup_process_coding_systems (Lisp_Object);
# define CHILD_SETUP_ERROR_DESC "Doing vfork"
#endif
extern CHILD_SETUP_TYPE child_setup (int, int, int, char **, bool, Lisp_Object);
extern CHILD_SETUP_TYPE child_setup (int, int, int, char **, Lisp_Object);
extern void init_callproc_1 (void);
extern void init_callproc (void);
extern void set_initial_environment (void);

4
src/process.c
View file

@ -2254,9 +2254,9 @@ create_process (Lisp_Object process, char **new_argv, Lisp_Object current_dir)
if (forkerr < 0)
forkerr = forkout;
#ifdef WINDOWSNT
pid = child_setup (forkin, forkout, forkerr, new_argv, 1, current_dir);
pid = child_setup (forkin, forkout, forkerr, new_argv, current_dir);
#else /* not WINDOWSNT */
child_setup (forkin, forkout, forkerr, new_argv, 1, current_dir);
child_setup (forkin, forkout, forkerr, new_argv, current_dir);
#endif /* not WINDOWSNT */
}