Encourage https: in commit messages
* CONTRIBUTE: Prefer https: when citing. * build-aux/git-hooks/commit-msg: Diagnose http: and ftp: URLs to FSF or GNU hosts.
This commit is contained in:
parent
def9715282
commit
3c78960a47
2 changed files with 13 additions and 0 deletions
|
@ -175,6 +175,9 @@ them right the first time, so here are guidelines for formatting them:
|
||||||
bug number NNNNN in the debbugs database. This string is often
|
bug number NNNNN in the debbugs database. This string is often
|
||||||
parenthesized, as in "(Bug#19003)".
|
parenthesized, as in "(Bug#19003)".
|
||||||
|
|
||||||
|
- When citing URLs, prefer https: to http: when either will do. In
|
||||||
|
particular, gnu.org and fsf.org URLs should start with "https:".
|
||||||
|
|
||||||
- Commit messages should contain only printable UTF-8 characters.
|
- Commit messages should contain only printable UTF-8 characters.
|
||||||
|
|
||||||
- Commit messages should not contain the "Signed-off-by:" lines that
|
- Commit messages should not contain the "Signed-off-by:" lines that
|
||||||
|
|
|
@ -66,6 +66,8 @@ exec $awk -v at_sign="$at_sign" -v cent_sign="$cent_sign" '
|
||||||
non_print = "[^[:print:]]"
|
non_print = "[^[:print:]]"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
c_lower = "abcdefghijklmnopqrstuvwxyz"
|
||||||
|
unsafe_gnu_url = "(http|ftp)://([" c_lower ".]*\\.)?(gnu|fsf)\\.org"
|
||||||
}
|
}
|
||||||
|
|
||||||
/^#/ {
|
/^#/ {
|
||||||
|
@ -125,6 +127,14 @@ exec $awk -v at_sign="$at_sign" -v cent_sign="$cent_sign" '
|
||||||
status = 1
|
status = 1
|
||||||
}
|
}
|
||||||
|
|
||||||
|
{
|
||||||
|
if (match($0, unsafe_gnu_url)) {
|
||||||
|
url = substr($0, RSTART, RLENGTH)
|
||||||
|
printf "Use https: URL instead of '\''%s'\'' in commit message\n", url
|
||||||
|
status = 1
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
$0 ~ non_print {
|
$0 ~ non_print {
|
||||||
print "Unprintable character in commit message"
|
print "Unprintable character in commit message"
|
||||||
status = 1
|
status = 1
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue