procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

(byte-compile-from-buffer): Check old-style backquotes after each `read'

Browse source 
rather than once per buffer to get more precise location info.
This commit is contained in:
Stefan Monnier 2007-08-23 18:19:56 +00:00
parent 78b35906a9
commit 36e65f7059
2 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lisp/ChangeLog
View file

@ -1,5 +1,8 @@
2007-08-23 Stefan Monnier <monnier@iro.umontreal.ca> 2007-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
* emacs-lisp/bytecomp.el (byte-compile-from-buffer): Check old-style
backquotes after each `read' rather than once per buffer.
* dframe.el: Remove spurious * in custom docstrings. * dframe.el: Remove spurious * in custom docstrings.
(dframe-xemacsp): Remove, use (featurep 'xemacs) instead. (dframe-xemacsp): Remove, use (featurep 'xemacs) instead.
(dframe-xemacs20p): Remove, inline at the sole use point. (dframe-xemacs20p): Remove, inline at the sole use point.

16
lisp/emacs-lisp/bytecomp.el
View file

@ -1821,7 +1821,6 @@ With argument, insert value in current buffer after the form."
;; new in Emacs 22.1. ;; new in Emacs 22.1.
(read-with-symbol-positions inbuffer) (read-with-symbol-positions inbuffer)
(read-symbol-positions-list nil) (read-symbol-positions-list nil)
(old-style-backquotes nil)
;; #### This is bound in b-c-close-variables. ;; #### This is bound in b-c-close-variables.
;; (byte-compile-warnings (if (eq byte-compile-warnings t) ;; (byte-compile-warnings (if (eq byte-compile-warnings t)
;; byte-compile-warning-types ;; byte-compile-warning-types
@ -1859,19 +1858,20 @@ With argument, insert value in current buffer after the form."
(not (eobp))) (not (eobp)))
(setq byte-compile-read-position (point) (setq byte-compile-read-position (point)
byte-compile-last-position byte-compile-read-position) byte-compile-last-position byte-compile-read-position)
(let ((form (read inbuffer))) (let* ((old-style-backquotes nil)
(form (read inbuffer)))
;; Warn about the use of old-style backquotes.
(when old-style-backquotes
(byte-compile-warn "!! The file uses old-style backquotes !!
This functionality has been obsolete for more than 10 years already
and will be removed soon. See (elisp)Backquote in the manual."))
(byte-compile-file-form form))) (byte-compile-file-form form)))
;; Compile pending forms at end of file. ;; Compile pending forms at end of file.
(byte-compile-flush-pending) (byte-compile-flush-pending)
;; Make warnings about unresolved functions ;; Make warnings about unresolved functions
;; give the end of the file as their position. ;; give the end of the file as their position.
(setq byte-compile-last-position (point-max)) (setq byte-compile-last-position (point-max))
(byte-compile-warn-about-unresolved-functions) (byte-compile-warn-about-unresolved-functions))
;; Warn about the use of old-style backquotes.
(when old-style-backquotes
(byte-compile-warn "!! The file uses old-style backquotes !!
This functionality has been obsolete for more than 10 years already
and will be removed soon. See (elisp)Backquote in the manual.")))
;; Fix up the header at the front of the output ;; Fix up the header at the front of the output
;; if the buffer contains multibyte characters. ;; if the buffer contains multibyte characters.
(and filename (byte-compile-fix-header filename inbuffer outbuffer)))) (and filename (byte-compile-fix-header filename inbuffer outbuffer))))