procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add a few warnings about special event structures on X

Browse source 
* xterm.c (x_construct_mouse_click)
(x_note_mouse_movement): Add comments explaining the nature of
some special event structures.
This commit is contained in:
Po Lu 2022-03-04 20:54:02 +08:00
parent f685bcb65d
commit 345c4c6532
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/xterm.c
View file

@ -6806,7 +6806,16 @@ get_keysym_name (int keysym)
/* Prepare a mouse-event in *RESULT for placement in the input queue.
If the event is a button press, then note that we have grabbed
the mouse. */
the mouse.
The XButtonEvent structure passed as EVENT might not come from the
X server, and instead be artificially constructed from input
extension events. In these special events, the only fields that
are initialized are `time', `button', `state', `type', `window' and
`x' and `y'. This function should not access any other fields in
EVENT without also initializing the corresponding fields in `bv'
under the XI_ButtonPress and XI_ButtonRelease labels inside
`handle_one_xevent'. */
static Lisp_Object
x_construct_mouse_click (struct input_event *result,
@ -6849,7 +6858,15 @@ x_construct_mouse_click (struct input_event *result,
We have received a mouse movement event, which is given in *event.
If the mouse is over a different glyph than it was last time, tell
the mainstream emacs code by setting mouse_moved. If not, ask for
another motion event, so we can check again the next time it moves. */
another motion event, so we can check again the next time it moves.
The XMotionEvent structure passed as EVENT might not come from the
X server, and instead be artificially constructed from input
extension events. In these special events, the only fields that
are initialized are `time', `window', and `x' and `y'. This
function should not access any other fields in EVENT without also
initializing the corresponding fields in `ev' under the XI_Motion,
XI_Enter and XI_Leave labels inside `handle_one_xevent'. */
static bool
x_note_mouse_movement (struct frame *frame, const XMotionEvent *event)