procyberian/emacs
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use black-on-white by default for doc-view-svg-face.

Browse source 
* lisp/doc-view.el (doc-view-svg-face): Define black on white as
default value instead of using the current theme's values.
* etc/NEWS: Adjust entry for doc-view-svg-face.
This commit is contained in:
Tassilo Horn 2024-09-23 18:50:29 +02:00
parent 32d0c8f6af
commit 2b53e11a08
2 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
etc/NEWS
View file

@ -1544,10 +1544,12 @@ default is non-nil if your system supports display of SVG images.
--- ---
*** New face 'doc-view-svg-face'. *** New face 'doc-view-svg-face'.
This replaces 'doc-view-svg-foreground' and 'doc-view-svg-background'. This replaces 'doc-view-svg-foreground' and 'doc-view-svg-background'.
If you don't like the colors produced by the default definition of By default, this face has black foreground on white background and
this new face when DocView displays documents, customize this face to inherits from the default face. When unsetting the foreground and
restore the colors you were used to, or to get colors more to your background values, the display in DocView is styled according to the
liking. current theme. However, this, or any non-standard values, can result in
poor contrast for documents which aren't simply black text on white
background.
--- ---
*** DocView buffers now display a new tool bar. *** DocView buffers now display a new tool bar.

11
lisp/doc-view.el
View file

@ -238,10 +238,15 @@ showing only titles and no page number."
:type 'boolean :type 'boolean
:version "29.1") :version "29.1")
(defface doc-view-svg-face '((t :inherit default)) (defface doc-view-svg-face '((t :inherit default
:background "white"
:foreground "black"))
"Face used for SVG images. "Face used for SVG images.
Only background and foreground colors are used. See `doc-view-mupdf-use-svg'.
See `doc-view-mupdf-use-svg'."
Only background and foreground colors are used as the SVG image's
descriptors, see (info \"(elisp) SVG Images\"). Non-standard values may
cause low-contrast issues with certain documents."
:version "30.1") :version "30.1")
(make-obsolete 'doc-view-svg-background 'doc-view-svg-face "30.1") (make-obsolete 'doc-view-svg-background 'doc-view-svg-face "30.1")