From ff21717f05b2cd48015a8c05d89a1ff7e598fb1b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattias=20Engdeg=C3=A5rd?= Date: Wed, 9 Aug 2023 10:23:28 +0200 Subject: [PATCH 1/2] Disable failing test (bug#65156) * test/src/fileio-tests.el (fileio-tests--non-regular-insert): Mark as :unstable, since /dev/urandom is seekable. Do not merge to master. --- test/src/fileio-tests.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/src/fileio-tests.el b/test/src/fileio-tests.el index 50642420ce9..5bc1024ff20 100644 --- a/test/src/fileio-tests.el +++ b/test/src/fileio-tests.el @@ -194,6 +194,8 @@ Also check that an encoding error can appear in a symlink." (should (equal (file-name-concat "" "") ""))) (ert-deftest fileio-tests--non-regular-insert () + ;; Fails in Emacs 29 because /dev/urandom is typically seekable (bug#65156) + :tags '(:unstable) (skip-unless (file-exists-p "/dev/urandom")) (with-temp-buffer (set-buffer-multibyte nil) From 7e3c616086014e883490d537509c9641a87ed19b Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Wed, 9 Aug 2023 07:25:59 -0400 Subject: [PATCH 2/2] ; Re-enable the /dev/urandom test * test/src/fileio-tests.el (fileio-tests--non-regular-insert): Remove :unstable, but comment out the single failing test. --- test/src/fileio-tests.el | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/src/fileio-tests.el b/test/src/fileio-tests.el index 5bc1024ff20..fea7eeea753 100644 --- a/test/src/fileio-tests.el +++ b/test/src/fileio-tests.el @@ -194,12 +194,11 @@ Also check that an encoding error can appear in a symlink." (should (equal (file-name-concat "" "") ""))) (ert-deftest fileio-tests--non-regular-insert () - ;; Fails in Emacs 29 because /dev/urandom is typically seekable (bug#65156) - :tags '(:unstable) (skip-unless (file-exists-p "/dev/urandom")) (with-temp-buffer (set-buffer-multibyte nil) - (should-error (insert-file-contents "/dev/urandom" nil 5 10)) + ;; Fails in Emacs 29 because /dev/urandom is typically seekable (bug#65156) + ;(should-error (insert-file-contents "/dev/urandom" nil 5 10)) (insert-file-contents "/dev/urandom" nil nil 10) (should (= (buffer-size) 10))))