procyberian/emacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

; Fix doc string in ERC's module-activation commands

Browse source 
* lisp/erc/erc-common.el (erc--assemble-toggle): Previously, the doc
string implied that a prefix argument was necessary to achieve
connection-wide effects, which might lead a person to think the
interactive code should be an uppercase "P".
* test/lisp/erc/erc-tests.el (define-erc-module--local): Update
expected result of code-gen.
This commit is contained in:
F. Jason Park 2022-12-15 23:25:10 -08:00
parent 5a9263a872
commit 173e02f4eb
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lisp/erc/erc-common.el
View file

@ -130,7 +130,8 @@ canonical name.")
(if val "Enable" "Disable")
" ERC " (symbol-name name) " mode."
(when localp
"\nWith ARG, do so in all buffers for the current connection."))
(concat "\nWhen called interactively,"
" do so in all buffers for the current connection.")))
(interactive ,@(when localp '("p")))
,@(if localp
`((when (derived-mode-p 'erc-mode)

4
test/lisp/erc/erc-tests.el
View file

@ -1331,7 +1331,7 @@ Some docstring"
(defun erc-mname-enable (&optional ,arg-en)
"Enable ERC mname mode.
With ARG, do so in all buffers for the current connection."
When called interactively, do so in all buffers for the current connection."
(interactive "p")
(when (derived-mode-p 'erc-mode)
(if ,arg-en
@ -1343,7 +1343,7 @@ With ARG, do so in all buffers for the current connection."
(defun erc-mname-disable (&optional ,arg-dis)
"Disable ERC mname mode.
With ARG, do so in all buffers for the current connection."
When called interactively, do so in all buffers for the current connection."
(interactive "p")
(when (derived-mode-p 'erc-mode)
(if ,arg-dis