Avoid unnecessary loading of subr-x at run-time

* lisp/doc-view.el, lisp/filenotify.el, lisp/info-look.el:
* lisp/svg.el, lisp/emacs-lisp/byte-opt.el, lisp/net/shr.el:
* lisp/textmodes/sgml-mode.el, test/lisp/dom-tests.el:
No need to load subr-x at run-time.
* lisp/gnus/nnheader.el: No need to load subr-x.
; * lisp/emacs-lisp/subr-x.el, lisp/gnus/message.el, lisp/net/nsm.el:
; Comments.

lisp/doc-view.el

@@ -140,7 +140,7 @@
 (require 'dired)
 (require 'image-mode)
 (require 'jka-compr)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
 
 ;;;; Customization Options
 

lisp/emacs-lisp/byte-opt.el

@@ -185,7 +185,7 @@
 (require 'bytecomp)
 (eval-when-compile (require 'cl-lib))
 (require 'macroexp)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
 
 (defun byte-compile-log-lap-1 (format &rest args)
   ;; Newer byte codes for stack-ref make the slot 0 non-nil again.

lisp/emacs-lisp/subr-x.el

@@ -30,6 +30,9 @@
 ;; Do not document these functions in the lispref.
 ;; http://lists.gnu.org/archive/html/emacs-devel/2014-01/msg01006.html
 
+;; NB If you want to use this library, it's almost always correct to use:
+;; (eval-when-compile (require 'subr-x))
+
 ;;; Code:
 
 (require 'pcase)

lisp/filenotify.el

@@ -28,7 +28,7 @@
 ;;; Code:
 
 (require 'cl-lib)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
 
 (defconst file-notify--library
   (cond

lisp/gnus/message.el

@@ -49,7 +49,7 @@
 (require 'mm-util)
 (require 'rfc2047)
 (require 'puny)
-(require 'subr-x)
+(require 'subr-x)			; read-multiple-choice
 
 (autoload 'mailclient-send-it "mailclient")
 

lisp/gnus/nnheader.el

@@ -40,7 +40,6 @@
 (require 'mail-utils)
 (require 'mm-util)
 (require 'gnus-util)
-(require 'subr-x)
 (autoload 'gnus-range-add "gnus-range")
 (autoload 'gnus-remove-from-range "gnus-range")
 ;; FIXME none of these are used explicitly in this file.

lisp/info-look.el

@@ -43,7 +43,7 @@
 ;;; Code:
 
 (require 'info)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
 
 (defgroup info-lookup nil
   "Major mode sensitive help agent."

lisp/net/nsm.el

@@ -25,7 +25,7 @@
 ;;; Code:
 
 (require 'cl-lib)
-(require 'subr-x)
+(require 'subr-x)                       ; read-multiple-choice
 
 (defvar nsm-permanent-host-settings nil)
 (defvar nsm-temporary-host-settings nil)

lisp/net/shr.el

@@ -33,7 +33,7 @@
 (eval-when-compile (require 'cl))
 (eval-when-compile (require 'url))      ;For url-filename's setf handler.
 (require 'browse-url)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
 (require 'dom)
 (require 'seq)
 (require 'svg)

lisp/svg.el

@@ -27,7 +27,7 @@
 (require 'cl-lib)
 (require 'xml)
 (require 'dom)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
 
 (defun svg-create (width height &rest args)
   "Create a new, empty SVG image with dimensions WIDTHxHEIGHT.

lisp/textmodes/sgml-mode.el

@@ -34,7 +34,7 @@
 
 (require 'dom)
 (require 'seq)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
 (eval-when-compile
   (require 'skeleton)
   (require 'cl-lib))

test/lisp/dom-tests.el

@@ -26,7 +26,7 @@
 
 (require 'dom)
 (require 'ert)
-(require 'subr-x)
+(eval-when-compile (require 'subr-x))
 
 (defun dom-tests--tree ()
   "Return a DOM tree for testing."