ses-test Prefix used symbols by ses--

* test/lisp/ses-tests.el: Rename cell symbols of renamed cells so
that they are in the SES namespace, as recommended by Stefan.
This commit is contained in:
Vincent Belaïche 2022-04-10 00:26:33 +02:00
parent 8b3748c234
commit 0b5c959db5

View file

@ -29,17 +29,17 @@
(with-suppressed-warnings ((lexical ses--cells)
(lexical A2)
(lexical A3)
(lexical foo)
(lexical bar)
(lexical ses--foo)
(lexical ses--bar)
(lexical B2)
(lexical toto))
(lexical ses--toto))
(defvar ses--cells)
(defvar A2)
(defvar A3)
(defvar foo)
(defvar bar)
(defvar ses--foo)
(defvar ses--bar)
(defvar B2)
(defvar toto))
(defvar ses--toto))
;; PLAIN FORMULA TESTS
;; ======================================================================
@ -71,7 +71,7 @@ equal to 2. This is done using interactive calls."
;; ======================================================================
(ert-deftest ses-tests-lowlevel-renamed-cell ()
"Check that renaming A1 to `foo' and setting `foo' to 1 and A2 to (1+ foo), makes A2 value equal to 2.
"Check that renaming A1 to `ses--foo' and setting `ses--foo' to 1 and A2 to (1+ ses--foo), makes A2 value equal to 2.
This is done using low level functions, `ses-rename-cell' is not
called but instead we use text replacement in the buffer
previously passed in text mode."
@ -85,63 +85,63 @@ previously passed in text mode."
(text-mode)
(goto-char (point-min))
(while (re-search-forward "\\<A1\\>" nil t)
(replace-match "foo" t t))
(replace-match "ses--foo" t t))
(ses-mode)
(should-not (local-variable-p 'A1))
(should (eq foo 1))
(should (equal (ses-cell-formula 1 0) '(ses-safe-formula (1+ foo))))
(should (eq ses--foo 1))
(should (equal (ses-cell-formula 1 0) '(ses-safe-formula (1+ ses--foo))))
(should (eq (bound-and-true-p A2) 2)))))
(ert-deftest ses-tests-renamed-cell ()
"Check that renaming A1 to `foo' and setting `foo' to 1 and A2
to (1+ foo), makes A2 value equal to 2."
"Check that renaming A1 to `ses--foo' and setting `ses--foo' to 1 and A2
to (1+ ses--foo), makes A2 value equal to 2."
(let ((ses-initial-size '(2 . 1)))
(with-temp-buffer
(ses-mode)
(ses-rename-cell 'foo (ses-get-cell 0 0))
(dolist (c '((0 0 1) (1 0 (1+ foo))))
(ses-rename-cell 'ses--foo (ses-get-cell 0 0))
(dolist (c '((0 0 1) (1 0 (1+ ses--foo))))
(apply 'funcall-interactively 'ses-edit-cell c))
(ses-command-hook)
(should-not (local-variable-p 'A1))
(should (eq foo 1))
(should (equal (ses-cell-formula 1 0) '(1+ foo)))
(should (eq ses--foo 1))
(should (equal (ses-cell-formula 1 0) '(1+ ses--foo)))
(should (eq (bound-and-true-p A2) 2)))))
(ert-deftest ses-tests-renamed-cell-after-setting ()
"Check that setting A1 to 1 and A2 to (1+ A1), and then
renaming A1 to `foo' makes `foo' value equal to 2."
renaming A1 to `ses--foo' makes `ses--foo' value equal to 2."
(let ((ses-initial-size '(2 . 1)))
(with-temp-buffer
(ses-mode)
(dolist (c '((0 0 1) (1 0 (1+ A1))))
(apply 'funcall-interactively 'ses-edit-cell c))
(ses-command-hook); deferred recalc
(ses-rename-cell 'foo (ses-get-cell 0 0))
(ses-rename-cell 'ses--foo (ses-get-cell 0 0))
(should-not (local-variable-p 'A1))
(should (eq foo 1))
(should (equal (ses-cell-formula 1 0) '(1+ foo)))
(should (eq ses--foo 1))
(should (equal (ses-cell-formula 1 0) '(1+ ses--foo)))
(should (eq (bound-and-true-p A2) 2)))))
(ert-deftest ses-tests-renaming-cell-with-one-symbol-formula ()
"Check that setting A1 to 1 and A2 to A1, and then renaming A1
to `foo' makes `foo' value equal to 1. Then set A1 to 2 and check
that `foo' becomes 2."
to `ses--foo' makes `ses--foo' value equal to 1. Then set A1 to 2 and check
that `ses--foo' becomes 2."
(let ((ses-initial-size '(3 . 1)))
(with-temp-buffer
(ses-mode)
(dolist (c '((0 0 1) (1 0 A1)))
(apply 'funcall-interactively 'ses-edit-cell c))
(ses-command-hook); deferred recalc
(ses-rename-cell 'foo (ses-get-cell 0 0))
(ses-rename-cell 'ses--foo (ses-get-cell 0 0))
(ses-command-hook); deferred recalc
(should-not (local-variable-p 'A1))
(should (eq foo 1))
(should (equal (ses-cell-formula 1 0) 'foo))
(should (eq ses--foo 1))
(should (equal (ses-cell-formula 1 0) 'ses--foo))
(should (eq (bound-and-true-p A2) 1))
(funcall-interactively 'ses-edit-cell 0 0 2)
(ses-command-hook); deferred recalc
(should (eq (bound-and-true-p A2) 2))
(should (eq foo 2)))))
(should (eq ses--foo 2)))))
;; ROW INSERTION TESTS
@ -165,8 +165,8 @@ to A2 and inserting a row, makes A2 value empty, and A3 equal to
(ert-deftest ses-tests-renamed-cells-row-insertion ()
"Check that setting A1 to 1 and A2 to (1+ A1), and then renaming A1 to `foo' and A2 to `bar' jumping
to `bar' and inserting a row, makes A2 value empty, and `bar' equal to
"Check that setting A1 to 1 and A2 to (1+ A1), and then renaming A1 to `ses--foo' and A2 to `ses--bar' jumping
to `ses--bar' and inserting a row, makes A2 value empty, and `ses--bar' equal to
2."
(let ((ses-initial-size '(2 . 1)))
(with-temp-buffer
@ -174,16 +174,16 @@ to `bar' and inserting a row, makes A2 value empty, and `bar' equal to
(dolist (c '((0 0 1) (1 0 (1+ A1))))
(apply 'funcall-interactively 'ses-edit-cell c))
(ses-command-hook)
(ses-rename-cell 'foo (ses-get-cell 0 0))
(ses-rename-cell 'ses--foo (ses-get-cell 0 0))
(ses-command-hook)
(ses-rename-cell 'bar (ses-get-cell 1 0))
(ses-rename-cell 'ses--bar (ses-get-cell 1 0))
(ses-command-hook)
(should (eq bar 2))
(ses-jump 'bar)
(should (eq ses--bar 2))
(ses-jump 'ses--bar)
(ses-insert-row 1)
(ses-command-hook)
(should-not (bound-and-true-p A2))
(should (eq bar 2)))))
(should (eq ses--bar 2)))))
;; JUMP tests
@ -231,15 +231,15 @@ to `bar' and inserting a row, makes A2 value empty, and `bar' equal to
(should (eq (ses--cell-at-pos (point)) 'B2)))))
(ert-deftest ses-jump-B2-renamed ()
"Test jumping to cell B2 after renaming it `toto'."
"Test jumping to cell B2 after renaming it `ses--toto'."
(let ((ses-initial-size '(3 . 3))
ses-after-entry-functions)
(with-temp-buffer
(ses-mode)
(ses-rename-cell 'toto (ses-get-cell 1 1))
(ses-jump 'toto)
(ses-rename-cell 'ses--toto (ses-get-cell 1 1))
(ses-jump 'ses--toto)
(ses-command-hook)
(should (eq (ses--cell-at-pos (point)) 'toto)))))
(should (eq (ses--cell-at-pos (point)) 'ses--toto)))))
(provide 'ses-tests)